Suitecrm: Status/State usage causing translation errors

[horus68]

Issue

SuiteCRM language files uses "State" as a constituent political entity (in the US there 50 "States" divided into counties or county-equivalents). But STATE is also used as situation/condition State.
On top of that "Status" is also used as condition.
But for many languages all 3 could be translated with the same word!
This causes issues when in single word language values, as there is no context, making it impossible for translators to make a proper job. But it also may cause issues for devs using STATE strings in future.
Note: I'm not talking on the strings that uses "Address State" as this shows an obvious use, just the single words as they do not give any context.

Actual Behavior

Values used as a single word:

• 6 strings with "State" used for situation, condition. Examples: 'LBL_STATE' => 'State:', or 'LBL_LIST_STATE' => 'State', or 'LBL_AN_SERVICE_STATE' => 'State',
• 13 strings for "State" used in address fields for a Region. Examples: 'LBL_STATE' => 'State:', or 'LBL_LIST_STATE' => 'State',
• 73 strings for "Status". Examples: 'LBL_STATUS' => 'Status:' or 'LBL_LIST_STATUS' => 'State',

Possible Fix

"Easy" fix: to change "State" (when political entity) values in language files into a new value.
As Regional political entity/divisions are different in each countries (some don't even have any) no single word seems a proper one to also be used in english.
This "State" should be considered as the main regional administrative division. It could be regions, districts or provinces, and can be different in different countries. https://en.wikipedia.org/wiki/District

So my proposal is to use a value State or Region. Example:
'LBL_STATE' => 'State or Region:', //For address fields

Then each translator can pick a word suitable for their own country/language equivalent political entity.
A proper fix would also require to also change the key part of the language string so there would not be errors from the devs when using/creating a string for STATE.

Context

In Crowdin I already changed this a long time ago but this requires me to keep a local non synchronized copy from Github to Crowdin with my local edits and this a time consuming when updating source files.

Additional note:

You can also find "Status" and "State" in the same screen, and none are used as a political entity, so its not possible to change all non political "State" for "Status" occurrences:

State as address

[horus68]

@Dillon-Brown I can make a PR for this using "State or Region" when its used for address fields
'LBL_STATE' => 'State or Region:', //For address fields

but I do need your OK for this renaming as there could be a better wording then mine!

[pgorod]

@horus68 I agree with you that it would be nice to get this cleared up.

(you might want to rename this issue to fix the typo: Sate / State)

[cameronblaikie]

Hi @horus68 as of right know i have only change the label to "State/Region", but we're thinking that we should change the label to LBL_ADDRESS_STATE to identify that, that label is for an address. What are your thoughts on this?
Thanks!

[horus68]

Agree for "LBL_ADDRESS_STATE"
Same should be used for "Title" and "Job Title". See issue: https://github.com/salesagility/SuiteCRM/issues/7642

[cameronblaikie]

@horus68 Yes i agree for "Title" and "Job Title" as i am working on that today :+1: