Suitecrm: SuiteSpots localization

[likhobory]

Subj.
All this strings dispayed in English only: https://github.com/salesagility/SuiteCRM/blob/v7.7-rc/include/javascript/suitespots/suitespots.js#L346-L401

[horus68]

@samus-aran request to be tagged as High priority and solves before 7.7 release

[ghost]

Hi @likhobory. Can you please test this pull request and let me know if you have any problems. I have tested this for English, French and Russian and everything appears to work as expected.
Many thanks.

[likhobory]

Hi @paulgodley
I have tested it, but all function names in the charts are still not translated.

[ghost]

Hi @likhobory does it work for the table for you? Can you please try the table view and also try repairing the javascript language files (under admin->repair).

[likhobory]

It works fine in the table view.

try repairing the javascript language files (under admin->repair).

The same result in the chart view.

[ghost]

Hi @likhobory, I had not picked up on this with the charting library. I will let you know when this is resolved.

[ghost]

Hi @likhobory. I have updated the charting library to use the translated values for the x and y axis. I have also taken out the title. The only other item on your chart that I can see is the "Count" next to Russia and USA. Can you please attach a screen shot of the pivot layout (the columns and headers / options) you had selected to create this graph?

Please try out the update and let me know if it solves the issues for you.
Many thanks.

[likhobory]

Hi @paulgodley.
All labels has been translated except function name in the chart legend.
And chart is not displaying anything in the title.

[likhobory]

Hmm.. I have updated DB with "clean" demo data and now all labels in the legend are displayed correctly.
Did you remove any information from the chart title?

[ghost]

Hi @likhobory, I have removed the title. The "count" that you are seeing comes from the c3 library, rather than the pivot table js library. We are having a look at how to get the translations in place without changing c3 as this means that we are able to upgrade the library without having to modify it each time.

[likhobory]

ok, thanks.

[likhobory]

Hi ,
Is there any news about Spot localization?

[samus-aran]

@likhobory From the looks of the thread with the user been deleted we will need to establish how much more to go with this - but should be able to at least get the stuff done so far into review.

[recci]

@likhobory What more remains to be done for this? As far as I can see everything has been translated in the graph you posted?

[likhobory]

Because I have tested it with files from @paulgodley's branch (SuiteCRM-piDataTranslate) and this branch has been removed from GitHub. But I can attach a backup if you need.

[recci]

I dont understand. Does what is in paulgodley's branch fix all the translation issues in this bug report? If so Ill copy his work in and submit a new pull request.

[likhobory]

Yes, it fix the translation issues.
But paulgodley said that there is some issues with c3 library:

The "count" that you are seeing comes from the c3 library, rather than the pivot table js library. We are having a look at how to get the translations in place without changing c3 as this means that we are able to upgrade the library without having to modify it each time.

[recci]

Do you still see this "count" he is talking about?

[likhobory]

No, after updating DB with "clean" demo data.

[likhobory]

Hi @recci ,
Any news?

[recci]

Iv left saleagility now so up to them to deal with it. Looked good to go to me.

[likhobory]

Any news about localization?

[horus68]

@shogunpol can you please take a look into this? There is a PR created but against the proper branch. The user didn't fixed it after a request so maybe it requires you to create a new PR using the proposals

[shogunpol]

@horus68 , i did some revision of this PR, and looks like some work need to be done to deal with conflicts between this PR and hotfix branch.

[horus68]

@Dillon-Brown planned to be merged soon?

[lucas7793]

Are there any news about this issue?

[Mausino]

@samus-aran @Dillon-Brown planned to be merged soon the patches?
@lucas7793 @likhobory @horus68 should you please confirm that the patch is working for you?

[likhobory]

I confirm, this patch is tested on version 7.7.0 and PR #6646 is tested on version 7.10.11