Stylus: Darken the background under the editor's moz-import dialog

Created on 11 Oct 2017  路  5Comments  路  Source: openstyles/stylus

chrome-extension---lfnlmiimoamfidmfgcfeenahdaoaehkc-edit html-fs8

This will emphasize that this is just a dialog, not a style editor, especially in case it's automatically shown on pasting.

Most helpful comment

I don't see why not. No shame in taking the path of least resistance IMO:

#help-popup.big {
    box-shadow: hsla(0, 0%, 0%, .7) 0px 0px 0px 100000px;
}

All 5 comments

I don't see why not. No shame in taking the path of least resistance IMO:

#help-popup.big {
    box-shadow: hsla(0, 0%, 0%, .7) 0px 0px 0px 100000px;
}

not-sure-if-laughing-at-me-or-with-me

Huh, performance profiling doesn't show any problems with this approach. @narcolepticinsomniac, please push the commit.

Uhm, correction: .5 or lower for transparency would be more consistent with other backdrops we have (.35 in the popup's confirm and .25 in the manager's message box).

Popup's confirm was actually .4, which I think is good. The others being much larger, .45 looked consistent to me, so I used that for moz-import and switched the manager's message box to that as well. Also used !important declaration on moz-import because it may be necessary to override user-CSS from themes. I think it's good, but feel free to tweak it if you want.

Was this page helpful?
0 / 5 - 0 ratings