Styled-components: Remove deprecated ThemeProvider channel

Created on 18 Mar 2018  路  3Comments  路  Source: styled-components/styled-components

We have had this deprecated theme channel for a while now, and it should be removed.

It's quite a simple task since nothing should be depending on it anymore, but it does involve some "housekeeping" task of checking whether there's any leftovers, renaming the new CHANNEL, and checking libraries that might depend on it still.

https://github.com/styled-components/styled-components/blob/master/src/models/ThemeProvider.js#L80-L88

good first issue help wanted
Source
picture kitten

Most helpful comment

We should probably just do this in one sweep while moving to the new context API, otherwise we end up breaking the ecosystem twice. Ref #1459

picture mxstbr on 19 Mar 2018
👍2

All 3 comments

We should probably just do this in one sweep while moving to the new context API, otherwise we end up breaking the ecosystem twice. Ref #1459

mxstbr picture mxstbr on 19 Mar 2018
👍2

Hey @kitten @mxstbr! Should I give it a try and remove ThemeProvider channel or the changes will be made alongwith the new context API itself?

pnkapadia6 picture pnkapadia6 on 20 Mar 2018

Closing this since we now have moved to the new context API #1894

alexandernanberg picture alexandernanberg on 12 Aug 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

robbue picture robbue  路  3Comments
garmjs picture garmjs  路  3Comments
arstin picture arstin  路  3Comments
lazopm picture lazopm  路  3Comments
const-g picture const-g  路  3Comments