Styled-components-website: Remove NextJS section inline snippet and a typo

Created on 3 Nov 2017  路  7Comments  路  Source: styled-components/styled-components-website

https://www.styled-components.com/docs/advanced#nextjs

As our inline snippet exactly matches with NextJS repository why we still have it here? Also there's a type fro -> for

/cc @mxstbr @philpl

enhancement good first issue

All 7 comments

On the one hand it鈥檚 good for convenience on the other we don鈥檛 have to keep it up to date and can just keep linking to the next repo.

I鈥檇 be happy if anyone would like to pick this up :)

Hi! I'd love to help out with this! I'll see what I can do :)

screen shot 2017-11-08 at 9 25 13 pm
Is this what you want for the Next.js section? @morajabi @philpl

Thanks, @danielzy95 awesome!

@philpl What do you think about adding a one-paragraph explanation of what they should do? (since there's not one in the example repo) For example:

Basically you need to add a custom pages/_document.js (if you don't have one). Then copy the logic for styled-components to inject the server side rendered styles into the <head>. You'll also need to customize the .babelrc and use babel-plugin-styled-components.

@morajabi sounds perfect!

@morajabi So you'd like me to add that paragraph to the Next.js section?

@morajabi @philpl My PR got merged :) I think you can close this issue now

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kitten picture kitten  路  6Comments

mxstbr picture mxstbr  路  7Comments

mxstbr picture mxstbr  路  5Comments

niraj8 picture niraj8  路  5Comments

Sshetty2 picture Sshetty2  路  6Comments