Strongbox: Make sure the LdapAuthenticatorConfigurationController is following the How-To-Write-Controllers guide

[steve-todorov]

The LdapAuthenticatorConfigurationController needs to be refactored a bit so that it is following the How-To-Implement-Spring-Controllers. It looks like the toError method, which is stored in the BaseController, can be deleted after the refactoring. Use the appropriate getSuccessful/getFailed/getNotFound/getBadRequest/etc methods from the BaseController instead.

[ptirador]

I'll take it!

[ptirador]

There are a few metods that produce MediaType.APPLICATION_XML_VALUE. Should they still produce it? Just asking.

• getRolesMapping
• getUserDnPatterns
• getUserSearchFilter
• getGroupSearchFilter

[steve-todorov]

I'm not sure if that will be necessary. I would leave only the JSON as having output XML will do no good for the front-end. @carlspring thoughts?

[carlspring]

I think these should be both in XML and JSON. What do you guys think?

[ptirador]

I agree with @steve-todorov on this one.

[carlspring]

Okay then, please proceed as you find fit!