Streetcomplete: AddRecyclingContainerMaterialsForm.kt - spelling mistakes

Created on 19 Apr 2020  路  7Comments  路  Source: westnordost/StreetComplete

The AddRecyclingContainerMaterialsForm quests asks to add "recycling:electric_appliances" as key, but this key is not used anywhere.

We have plenty other keys for the large and small devices already:

4000x recycling:electrical_appliances
3700x recycling:small_appliances
1000x recycling:electrical_items
560x recycling:small_electrical_appliances

bug

All 7 comments

Oh damn, you are right. This ticket will remain open until well after the fix was released so that I remember to manually clean up the mistaggings.

I find very very few usages of recycling:electric_appliances on taginfo, have you been correcting them? If yes, to what tag?

Tags used in combination with recycling_type = container worldwide:

| tag | yes | no | documented in wiki |
| ---- | ---- | ---- | ----- |
| recycling:small_appliances | 745 | 1424 | listed but without explanation. Probably any small appliances, whether electrical or not |
| recycling:small_electrical_appliances | 463 | 10 | described as pretty much what is shown to the user in StreetComplete:
|
| recycling:electrical_appliances | 490 | 1641 | described as "large" appliances, like freezers |

Thus, I conclude that recycling:small_electrical_appliances is the correct tag to use in this case.

Yes, I corrected a couple of them. I didn't notice that it's from a software issue, so I treated them like a simple spelling mistake and corrected them to the closest tag, 'electrical_appliances'.

Seems like there are 12 nodes where I'm the last editor:
http://overpass-turbo.eu/s/T5C

Ah okay, as researched, I think these should actually be recycling:small_electrical_appliances because that is what is shown to the user.

The tagging of "electric containers" is a bit weird, yes.

But I think what has to be differentiated are really the "big" electrical applicances and the "small" ones.

So when looking at tagging:

Also, when choosing recycling:electrical_appliances for the small _and_ the big ones, then the key for only the small ones should be recycling:small_electrical_appliances, and not recycling:small_appliances or something else. So westnordost is right.

This can be closed now. In taginfo, I see no more occurances of recycling:electric_appliances and v19 has been out for a while.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

lost-geographer picture lost-geographer  路  3Comments

RubenKelevra picture RubenKelevra  路  4Comments

lzmartinico picture lzmartinico  路  4Comments

JulienPalard picture JulienPalard  路  3Comments

RubenKelevra picture RubenKelevra  路  3Comments