Streetcomplete: Adding religion quest to more features

[Dosenpfand]

The religion quest could easily be exended to include at least the following additional features:

1. cemetery
2. grave yard
3. monastery

I implemented a first draft for cemeteries and can expand it and open a pull request if desired.

General

Affected tag(s) to be modified/added: religion
Question asked: What religion is represented at this cemetery?

Checklist

Checklist for quest suggestions (see guidelines):

• [X] 🚧 To be added tag is established and has a useful purpose
• [X] 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
• [X] 🐿️ Easily answerable by everyone from the outside but a survey is necessary
• [X] 💤 Not an overwhelming percentage of elements have the same answer (No spam)
• [X] 🕓 Applies to a reasonable number of elements (Worth the effort)

Ideas for implementation

Element selection: "nodes, ways, relations with landuse = cemetery and !religion"

Metadata needed: N/A

Proposed GUI:
Similar to adding religion to places of worship and wayside shrines.

[westnordost]

Cemeteries and graveyards are problematic because oftentimes there will be no sign or something like that that will shed light on for which religion (if any, or any specific one, by the way) this is.
Monasteries could maybe be integrated into the place of worship quest.

[matkoniecz]

Monasteries make sense.

But cemeteries may have a tricky issue. In Poland many cemeteries are operated by local government, open for people of any religion but all (or nearly all) graves are using christian symbols (crosses etc). One may easily add an incorrect religion=christian.

[westnordost]

So, let's go with monasteries only. Would you like to create a PR for that yourself?

[Dosenpfand]

I can create the pull request.
I assume it should be created as seperate class e.g. AddReligionToMonastery? Additionally, places of worship are currently only displayed if they have a name, is there any specific reason for that? Should that be handled the same way for monasteries?

[westnordost]

No, doesn't need to be separate as the icon can be the same and the current wording fits for monasteries as well.

Hmm, I guess a name is not necessary to identify a highlighted place. You can extend it to include also places of worships that do not have a name, but then you need to add a second string for unnamed places of worship. See for example AddBusStopShelter how this can be done. The text should then just ask the religion of the "place".