Streetcomplete: AddTactilePavingBusStop Quest Prompts for Railway and Subway platforms with confusing text

Created on 29 Sep 2019  路  7Comments  路  Source: westnordost/StreetComplete

How to Reproduce
This way offers the tactile paving quest:
https://www.openstreetmap.org/way/569053687

"Does the bus stop ... have tactile paving?"

Versions affected
Android 9, SC 14.1

Personally I'm not against the quest and I don't think it needs to be restricted, but it would be good if different text was displayed for the various transport types, similar to what was done to fix #806 .

In an ideal world, different icons would be good too, but I assume it then becomes lots of different quests and perhaps that isn't worth the coding overhead.

bug

All 7 comments

Thanks for spotting and reporting!

requires equivalent of https://github.com/westnordost/StreetComplete/commit/7780b7308188790992b188e676eb7f28b1686003

AddBusStopName.kt, AddWheelchairAccessPublicTransport.kt, AddBusStopShelter.kt should be free from this bug

Do we actually want to restrict (which seems unnecessary to me), or just have multiple worded prompts?

I'm hoping we can come up with some text that covers subway and railway as one (e.g. platform and train). I guess AddWheelchairAccessPublicTransport.kt might be inspiration there.

Edit, I see it actually has different text for different cases, which works well:
https://github.com/westnordost/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessPublicTransport.kt#L21-L35

It should probably also cover railway=platform_edge:
https://wiki.openstreetmap.org/wiki/Tag:railway=platform%20edge?uselang=en-GB

Thanks @westnordost . It seems a shame not to cover railway and subway too though; whereas you've explicitly excluded them, or should I open a new enhancement/new quest to cover them?

if were allready there we could add text for Tram stops tram=yes (and why not also Light Rail,Monorail Aerialway,Funicular)
and while were add it how about doing the same for amenity=ferry_terminal

Well, it could be a new quest. Code-wise, "new quests" are really really little work.

Logically it feels like it probably just needs to be more different text prompts on the existing one, like where you added tram.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

RubenKelevra picture RubenKelevra  路  3Comments

forteller picture forteller  路  3Comments

RubenKelevra picture RubenKelevra  路  3Comments

ecksun picture ecksun  路  3Comments

tordans picture tordans  路  4Comments