Streetcomplete: (Wiki) site with list of all quests

[rugk]

Reasoning/user "stories"

For the following reasons, it would be nice to have a complete list of all quests available:

• For issue creators suggesting new quests/ideas, to see whether a quest is already implemented or there is a similar quest (ehm… https://github.com/westnordost/StreetComplete/issues/394 🙄)
• For developers/contributors, to check whether there is a similar quest (code) they can reuse.
• For users as "advertisement". "See how much quests you can answer here!" (potentially in conjunction with "And you can contribute your own ones!"). You could include it in app description, etc.
• For the curious, who don't know what is "hidden" behind these icons, but like to know…
• For OSM mappers, so they can see what things this app can modify/comment, etc.

And for various other user questions:

• For "Ehh, I saw an icon there once, but I do not remember what type of quest this is?"
• For "Hmm, can I also use this quest to answer XY?"
• For "I only see quests about street? Does this mean StreetComplete is only about streets?"

Concrete suggestion

I image a table or a similar format, which should contain the following elements (in the following or a similar order, ordered by importance):

1. Quest icon.
2. Quest name (short)
3. Quest question
4. What the quest means, if it is not clear OR an example OR a screenshot (may take too much space, however, but on the other hand also shows how the user input/selection is done)
5. Link to code where it is implemented, and – if it applies – link to resource files (YAML) used
6. Link to issue/discussion/PR, if there is one
7. (optional) link to example changeset or similar explanation/depiction of what may/is changed by this quest
8. (optional) since when (version number and/or date) the quest is included

I tried to include all the interests from the "user stories" above. Anyway, before anyone (including me) starts to make this table, let's first finish this discussion in this issue about what to include and in which order.

Why wiki?

Just because that may be a good thing for all users to maintain. And your wiki needs content… :wink:

[westnordost]

Within the app, there will be a list because #35. It will have the

• quest icon
• the quest question
  but not the name, because it does not exist yet and it would require another translation for each quest (and also not the other things).

This covers a few of your user stories.

Otherwise, if you find it useful - probably you do, because otherwise you woudn't suggest it - then you can start this in the OpenStreetMap wiki (i.e. here), I won't put this into the wiki here because only I can change the wiki here (even though it is called "wiki") and I will not maintain this list. This is too much work for me, I have other priorities.

Thus, I will close this issue, but feel free to create such a list.

By the way, the icons in the SVG have been added beforehand for possible quests, some icons are not used yet.

[rugk]

I won't put this into the wiki here because only I can change the wiki here (even though it is called "wiki") and I will not maintain this list

You can change this in the settings. So?

[HolgerJeromin]

I also planned an osm wiki page for quests, but did not had time. For me explaining the used queries would be important.
Ref closed #194

[rugk]

Great, so I see we should make it. The question is still:

1. Where? GitHub wiki or OSM? I had initially thought of GitHub as you can then find it easier and the OSM wiki is relatively unconnected/unrelated to this project, which is basically a software.
2. @westnordost still has not expressed any opinion about the criteria (table columns) I listed. Or does not matter it to you? (At least what to choose in the "OR" parts or the "(optional)" things would be nice.)

IMHO https://github.com/westnordost/StreetComplete/issues/35 is a: Well okay… it's a list. This, however, only covers some things, and is not the "in-depth" thing you can only list outside of the app for those who want to see it. (with links, etc.)
And BTW: Some "user stories" require that you can see the thing before installing/downloading the app.

[HolgerJeromin]

Where? GitHub wiki or OSM? I had initially thought of GitHub as you can then find it easier and the OSM wiki is relatively unconnected/unrelated to this project, which is basically a software.

Everyone have an account on osm wiki and knows the syntax.

https://wiki.openstreetmap.org/wiki/JOSM/Plugins/BuildingsTools is the same

[HolgerJeromin]

westnordost still has not expressed any opinion about the criteria (table columns) I listed.

everything can be changed. The layout will adapt to the content. just start :)

[rugk]

Everyone have an account on osm wiki and knows the syntax.

On GitHub too. On GitHub thanks to the possibility to use Markdown, the syntax is even easier… In the end it does not matter, I am just saying it here…

everything can be changed. The layout will adapt to the content. just start :)

No actually not. Not doing duplicate or unnecessary work here. First plan/make a concept, then start.

[westnordost]

@westnordost still has not expressed any opinion about the criteria (table columns) I listed. Or does not matter it to you?

I have no opinion on that.

[HolgerJeromin]

I saw many mappers (non programmers) which complains they need a Github account to report bugs.

[HolgerJeromin]

i think for a table we have too much information for every quest. So a wiki heading for every quest would be good. and than a ordered list like you started above
if we move to a new subpage for every quest this is easy, too

[rugk]

I saw many mappers (non programmers) which complains they need a Github account to report bugs.

Well… reporting bugs is one thing. Is table is something else…

if we move to a new subpage for every quest this is easy, too

Indeed. That's a good argument for the OSM wiki.

[rugk]

I began to create it: https://wiki.openstreetmap.org/wiki/StreetComplete/Quests
Still more a draft.

I still need to figure out, how to use css sprites (bec. of taht) in the wiki, though…

Also, IMHO it discourages quite much to work on an issue, which is closed. And there is ongoing work and open issues have a better chance to attract contributors. So, @westnordost, could you please reopen this issue?
It is clearly a community task and you do not need to work on it, but just so we have a discussion platform and an (open) issue for that, until the list is fully setup…

[westnordost]

Note that the mentioned spritesheet will soon vanish since the spritesheet is then generated automatically on each application start. (See quest-icons branch)

I propose to have a table:
Icon / Name / Since Version / Source link / Example changeset
and then in a second row for each quest (spanning all colums except perhaps icon & name) all varying info like further info, resource files, discussion, links to issues or whatever

[westnordost]

Regarding the icons: You can extract the icons from an APK (rename to ZIP) built from the quest-icons branch. Pngs of the vector icons are automatically created during the build process.

[Binnette]

It is better like this ?

[westnordost]

I like it better. Though, perhaps to reduce maintenance you could reduce title and name to simply "Add road surface" etc., not sure if the exact wording of the question is an important information.

But I am just giving input, you guys can do what you think makes sense.

By the way, wrong link to the source for housenumber. The link goes to the test class.

[rugk]

@Binnette Nice thing. How did you extract the housenumber icon?

By the way, wrong link to the source for housenumber. The link goes to the test class.

Fixed.

Though, perhaps to reduce maintenance you could reduce title and name to simply "Add road surface" etc.

So I changed the header to "question". IMHO the exact wording is useful to recognize a quest.

[rugk]

I also corrected the version numbers here using GitHub release notes. As I did, adding reference notes might be useful here.

May we also add "Affects"? Which show what this quest adjusts. At least in general categories (public transport, tourism, leisure… for wheelchair accessibility e.g.)

[rugk]

@westnordost I just saw you sometimes really added the "added quest" label in a later release version. THis is really confusing here as it makes it more difficult to find out, in which version a quest was added.

The best I see currently is to find the commit adding it and look at the earliest/lowest "tag value" on the top there…

[rugk]

No that does not work too. GItHub shows arbitrary versions/tags there… I have really no idea… @Binnette how did you get out the version numbers? Could you please reference sources in the wiki page?

[Binnette]

I get all versions by diging in every tags :pick:
I get code for evrey tags, then check what quests was added :+1:
About the housenumber picture, it is generated when you build SC. So i will add the others soon.

BTW : if you want to discuss about this wiki page, let's use this page : https://wiki.openstreetmap.org/wiki/Talk:StreetComplete/Quests
So @westnordost, we can close this bug :+1:

[rugk]

I get all versions by diging in every tags

Ouh, anyway you may then link to the specific version of a source code file or commit. (still wonder why GitHub does not show the correct tag(s) for a commit)

[rugk]

@Binnette What do you think about adding a column "Modifies" or "Applies", where, at least the broad categories of things modified are included. (for :wheelchair: wheelchair we can only use the broad categories as these are a lot…)
Or maybe (better) a column "affected tag", which links to the tag(s) this quest (primarily) modifies. I think for mappers, this is a useful information. Also maybe in order to know how to manually apply the change in case you accidentally wrongly answered a quest or so.

[Binnette]

My reponse on this page: https://wiki.openstreetmap.org/wiki/Talk:StreetComplete/Quests
Please let's talk abour the wiki... on the wiki :smile:

[rugk]

Regarding the icons: You can extract the icons from an APK (rename to ZIP) built from the quest-icons branch. Pngs of the vector icons are automatically created during the build process.

I tried to extract it from the main APK, then noticed you mentioned another branch. So one needs to built an apk to extract some images??

In any case SVGs are better anyway, so…

[rugk]

I am currently trying to split the SVG sprites into one SVG per quest icon.

Current results so far:
apple.zip
On wiki: https://wiki.openstreetmap.org/wiki/File:StreetComplete_quest_apple.svg

Tips:

• set the license in the meta data
• export as "SVG optimized", makes it smaller and removes
• I also press "Cleanup document" before, don't know if this makes a difference

However, now I also noticed the script export_svgs.py (where the executable bit is missing, BTW) could simplify that task. But I did not get how to use it. Passing the quest_icons.svg as a param to it, did not work (inkscape crashed). So how can one use it?

[westnordost]

The quest icons branch does not exist anymore, it is now on master.

[westnordost]

export_svgs.py does not work because of either a missing feature or a bug in Inkscape (I forgot).

The way I did it to convert the icons in the big icon sheet svg is to copy paste every single icon into an own SVG and save it.

[rugk]

So when you already converted them, where are they?

Also BTW, the best way to split the icon could be this: https://graphicdesign.stackexchange.com/questions/18088/exporting-an-object-as-svg-from-inkscape (does not need a new file for each icon and may be faster with keyboard usage)

[krzyk]

The are in android vector format at https://github.com/westnordost/StreetComplete/tree/master/app/src/main/res/drawable (ic_quest_*.xml)

[rugk]

Mhh, but not in SVG and I think converting from the Android format back to SVG is somehow lossy…

[rugk]

As @westnordost does not plan to split the SVG sprite I've now created a repo for all those split icons, as I have to store them somewhere and there they are nicely collected.

Repo: https://github.com/rugk/streetcomplete-quest-svgs

[HolgerJeromin]

@rugk Why do you have to store them somewhere? Uploading the splitted SVG to the wiki is not enough?

I have added categories to all icons. But we have an bug in wiki right now, so the category page is not working.

[rugk]

Uploading the splitted SVG to the wiki is not enough?

Yes, indeed, because I need them locally for extracting and I do need to compare the icons with the big SVG file. Also not all icons are visible in the wiki, as some icons do not have a quest yet.

[rugk]

See https://github.com/westnordost/StreetComplete/commit/4500cb6d08740cbc0fcda73bb475917241f56ff3#commitcomment-23923841

[rugk]

@Binnette Did you notice our discussion here about removing two columns? I'd still like to hear your feedback on this (or anybody else, FWIW), before doing that.

[rugk]

I finally deleted the columns…

[westnordost]

Should this ticket remain open?

[rugk]

@westnordost One question: Which quests where there since v0.1 of StreetComplete? The "opening hours" and road names quest?
Edit: And the building levels and roof shape?

Your release notes do not mention these.

[westnordost]

These two were there from the beginning, they were my proof-of-concept-quests, yes.

[rugk]

And the building levels and roof shape?

?

Also in the 1.0 release notes you state the speed limit quest was added, but at the same time, say you "improved" the same quest to "automatically use mph or km/h".

[rugk]

Another contradiction. In v0.11, you wrote:

new quest: pitches sport

In v1.0 you also wrote:

• added quests:
  
  
  
  • […]
  
  
  • sport(s) played on a pitch
  
  

So???

[rugk]

Also not mentioned in the release notes (but included in the app):

• tactile pavings for bus & crossing
• toilet fee
• and, BTW, when was the "note quest" introduced?

[westnordost]

OK, so the wiki thing is your project. I do not care at all about "since which version" any of the old quests were added and I will subsequently not put any time into researching this for you. Just a tip: If you want to keep this column, then just take the major version (0,1,2,...) and all is fine.

[rugk]

It's all right, you do not need to care about the wiki, but about your release notes. As I explained, they are contradictory, sometimes wrong or so.
Software needs proper (and, of course, correct)documentation, so you should fix that anyway.

[HolgerJeromin]

I think nobody really cares if a feature was new in beta 1 or 4.
westnordwest has more important stuff to do than fixing ancient changelogs

[rugk]

Yeah, that could be. Only for new releases it may be interesting, so users know they might need to upgrade to get a new quest type.

So maybe we combine all 0.x versions and just state "introduced in beta"?
And only track it for 1.0+?

[westnordost]

0.14 was not a beta.

[rugk]

The wiki page is finished as of the current state of the app. (2.0)
I've created a PR to add the link to the Readme here, so people can see it (in https://github.com/westnordost/StreetComplete/issues/607 yet another user requested it). See https://github.com/westnordost/StreetComplete/pull/618