Streamlink: pre-roll ads playing before twitch stream
Bug Report
- [x ] This is a bug report and I have read the contribution guidelines.
Description
streamlink 1.0.0 on windows 10 64bit (latest updates) has a chance of playing pre-roll ads before loading the twitch stream. sometimes it will partially play the end of an ad (i.e. 1 or 2 seconds), sometimes the entire ad. sometimes the ad is low resolution (480/720), sometimes 1080p. sometimes you get expected behavior (no ads).
Expected / Actual behavior
expected: play the stream straight away
actual: sporadic pre-rolls play, then the stream.
Reproduction steps / Explicit stream URLs to test
- use streamlink 1.0.0
- execute streamlink using cmd line "streamlink twitch.tv/sodapoppin best"
- other twitch streams can exhibit the same issue, but not always
Log output
C:\WINDOWS\system32>streamlink twitch.tv/sodapoppin best -l debug
[cli][info] Found matching plugin twitch for URL twitch.tv/sodapoppin
[plugin.twitch][debug] Getting live HLS streams for sodapoppin
[cli][info] Available streams: audio_only, 160p (worst), 360p, 480p, 720p, 720p60, 1080p60 (best)
[cli][info] Opening stream: 1080p60 (hls)
[cli][info] Starting player: "C:\mpv-x86_64-20190224\mpv.exe"
Additional comments, screenshots, etc.
configuration file is default save for player-passthrough enabled/default player changed to mpv.
video of the issue in action - https://mega.nz/#!HEBn1K4S!titCic2lUv4Hsz2c5LjY4TDvK2cjrHRS_Y_BbyO8COk
i'll stress that this is sporadic - sometimes i'll get an ad no matter how many times i load the stream. sometimes i won't get an ad at all. this first started happening for me on march 14th.
bonus: alternate player for twitch.tv plugin (chrome/firefox) has the same issue.
Love Streamlink? Please consider supporting our collective. Thanks!
ghost
All 33 comments
Doesn't Twitch embed some ads directly into the HLS playlist?
I don't now why this issue is appearing now because the system (Twitch calls it SureStream apparently) was announced 2016 (although it is labeled as "new" on the Twitch Advertisements page). Maybe it's just a bunch of companies actually buying SureStream Ad-Spots?
skulblakka
on 16 Mar 2019
correct, but it's never been an issue prior to this with either livestreamer or streamlink. partially played ads wouldn't be expected behavior on twitch's end, and ads triggered by streamers during their stream still don't play - imo, something has changed.
edit: ads triggered by the streamer now also affecting streamlink.
ghost
on 16 Mar 2019
It's because you're using player-passthrough. When you do that Streamlink isn't handling the stream, the player you are using is. If you disable player-passthrough this shouldn't be an issue any more. If it's happening without player-passthrough then we can open this back up to see if other people get the error as well.
gravyboat
on 16 Mar 2019
it's happening with player-passthrough disabled as well. video: https://mega.nz/#!HQo2hIDa!iKbbD0uRjICdtwHT3gc43aIrKVLxrBSrtqdjrZEn2pg
C:\>streamlink twitch.tv/mendokusaii best -l debug
[cli][info] Found matching plugin twitch for URL twitch.tv/mendokusaii
[plugin.twitch][debug] Getting live HLS streams for mendokusaii
[cli][info] Available streams: audio_only, 160p (worst), 360p, 480p, 720p, 720p60, 900p60 (best)
[cli][info] Opening stream: 900p60 (hls)
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 3 to queue
[cli][debug] Pre-buffering 8192 bytes
[stream.hls][debug] Adding segment 4 to queue
[stream.hls][debug] Adding segment 5 to queue
[stream.hls][debug] Download of segment 3 complete
[cli][info] Starting player: "C:\mpv-x86_64-20190224\mpv.exe"
[stream.hls][debug] Download of segment 4 complete
[stream.hls][debug] Download of segment 5 complete
[cli][debug] Writing stream to output
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 6 to queue
[stream.hls][debug] Adding segment 7 to queue
[stream.hls][debug] Download of segment 6 complete
[stream.hls][debug] Download of segment 7 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 8 to queue
[stream.hls][debug] Adding segment 9 to queue
[stream.hls][debug] Adding segment 10 to queue
[stream.hls][debug] Download of segment 8 complete
[stream.hls][debug] Download of segment 9 complete
[stream.hls][debug] Download of segment 10 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 11 to queue
[stream.hls][debug] Adding segment 12 to queue
[stream.hls][debug] Adding segment 13 to queue
[stream.hls][debug] Download of segment 11 complete
[stream.hls][debug] Download of segment 12 complete
[stream.hls][debug] Download of segment 13 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 14 to queue
[stream.hls][debug] Adding segment 15 to queue
[stream.hls][debug] Adding segment 16 to queue
[stream.hls][debug] Download of segment 14 complete
[stream.hls][debug] Download of segment 15 complete
[stream.hls][debug] Download of segment 16 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 17 to queue
[stream.hls][debug] Adding segment 18 to queue
[stream.hls][debug] Adding segment 19 to queue
[stream.hls][debug] Download of segment 17 complete
[stream.hls][debug] Download of segment 18 complete
[stream.hls][debug] Download of segment 19 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 20 to queue
[stream.hls][debug] Adding segment 21 to queue
[stream.hls][debug] Adding segment 22 to queue
[stream.hls][debug] Download of segment 20 complete
[stream.hls][debug] Download of segment 21 complete
[stream.hls][debug] Download of segment 22 complete
[cli][info] Player closed
[stream.hls][debug] Closing worker thread
[stream.hls][debug] Closing writer thread
[stream.hls][debug] Closing writer thread
[cli][info] Stream ended
[cli][info] Closing currently open stream...
ghost
on 16 Mar 2019
Weird, alright let's open this back up and see if others can duplicate. I haven't seen it since I've been using 1.0 so hopefully some others will chime in.
gravyboat
on 16 Mar 2019
You are not running Streamlink 1.0.0 if the environment debug infos are not showing up when using -l debug. Please don't cut this out from the log.
Are you able to reliably get ads when watching this channel via Streamlink (without passthrough)? If so, then you could check the HLS playlist content and see whether the ad-segments at the beginning have a different pattern. Example on *nix in bash (see the --stream-url parameter):
curl -s $(streamlink --stream-url twitch.tv/CHANNEL best) | less
There's also the --hls-segment-ignore-names parameter for filtering out HLS segments, but that probably won't be of use here due to dynamic file names.
As @skulblakka already said, Twitch has (tried to) embed ads into the HLS streams almost two years ago, but I've never seen any ads since their announcement of that feature, and Twitch streams are basically running all day long on my system. However, I've seen a reddit thread today where users of uBlock origin were complaining about getting ads, too, but others not. Maybe they're doing a field test in a specific region or so because of GDC next week, who knows.
Regarding actively blocking ads in Streamlink, I don't know how to feel about this. There hasn't been anything implemented to specifically block ads. Ads simply happened to be served from an external source and were loaded by the web player from there, so being ad-free was just a "coincidence". Blocking ads on a website with user tracking also has a different motivation. Projects like Streamlink however are relying on access to their API and have to worry about not breaking ToS (to a certain extent).
bastimeyer
on 16 Mar 2019
then we can open this back up to see if other people get the error as well.
I'm running 1.0.0 and I'm still getting it too. I'm also reliably getting ads on streams (including ad breaks).
Just to chime in before this somehow gets closed again and wiped from the board.
PEPEGAGRAVYBOAT
on 16 Mar 2019
You are not running Streamlink 1.0.0 if the environment debug infos are not showing up when using
-l debug. Please don't cut this out from the log.
version check tells me "1.0" is available despite uninstalling and reinstalling the 1.0.0 windows binary.
edit: as per the other issue thread, an old streamlink installation was clinging to life in local appdata. proper debug:
streamlink twitch.tv/destiny best -l debug
[cli][debug] OS: Windows 10
[cli][debug] Python: 3.6.6
[cli][debug] Streamlink: 1.0.0
[cli][debug] Requests(2.21.0), Socks(1.6.7), Websocket(0.54.0)
[cli][info] Found matching plugin twitch for URL twitch.tv/destiny
[plugin.twitch][debug] Getting live HLS streams for destiny
[utils.l10n][debug] Language code: en_GB
[cli][info] Available streams: audio_only, 160p (worst), 360p, 480p, 720p, 720p60, 1080p60 (best)
[cli][info] Opening stream: 1080p60 (hls)
[stream.hls][debug] Reloading playlist
[stream.hls][debug] First Sequence: 0; Last Sequence: 7
[stream.hls][debug] Start offset: 0; Duration: None; Start Sequence: 5; End Sequence: None
[stream.hls][debug] Adding segment 5 to queue
[cli][debug] Pre-buffering 8192 bytes
[stream.hls][debug] Adding segment 6 to queue
[stream.hls][debug] Adding segment 7 to queue
[stream.hls][debug] Download of segment 5 complete
[cli][info] Starting player: "C:\mpv-x86_64-20190224\mpv.exe"
[cli.output][debug] Opening subprocess: "C:\mpv-x86_64-20190224\mpv.exe" --title twitch.tv/destiny -
[stream.hls][debug] Download of segment 6 complete
[stream.hls][debug] Download of segment 7 complete
[cli][debug] Writing stream to output
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 8 to queue
[stream.hls][debug] Download of segment 8 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 9 to queue
[stream.hls][debug] Download of segment 9 complete
[stream.hls][debug] Reloading playlist
[stream.hls][debug] Adding segment 10 to queue
[stream.hls][debug] Download of segment 10 complete
[cli][info] Player closed
[stream.segmented][debug] Closing worker thread
[stream.segmented][debug] Closing writer thread
[stream.segmented][debug] Closing writer thread
[cli][info] Stream ended
[cli][info] Closing currently open stream...
Are you able to reliably get ads when watching this channel via Streamlink (without passthrough)?
If so, then you could check the HLS playlist content and see whether the ad-segments at the beginning have a different pattern. Example on *nix in bash (see the--stream-urlparameter):curl -s $(streamlink --stream-url twitch.tv/CHANNEL best) | lessThere's also the
--hls-segment-ignore-namesparameter for filtering out HLS segments, but that probably won't be of use here due to dynamic file names.
this is what the playlist shows from a stream that is realiably displaying ads.
```#EXTM3U
EXT-X-VERSION:3
EXT-X-TARGETDURATION:5
EXT-X-MEDIA-SEQUENCE:0
EXT-X-TWITCH-ELAPSED-SECS:12585.683
EXT-X-TWITCH-TOTAL-SECS:12601.683
EXT-X-DATERANGE:ID="stitched-ad-1552712664-17602000000",CLASS="twitch-stitched-ad",START-DATE="2019-03-16T05:04:24.476Z",DURATION=17.602,X-TV-TWITCH-AD-POD-POSITION="0",X-TV-TWITCH-AD-URL="https://www.amazon.co.uk/Amazon-Video/b?node=13827483031&ref=vm_uk_pr_ao_pd10t",X-TV-TWITCH-AD-ROLL-TYPE="PREROLL",X-TV-TWITCH-AD-POD-LENGTH="1"
EXT-X-DISCONTINUITY
EXT-X-SCTE35-OUT:URL="https://www.amazon.co.uk/Amazon-Video/b?node=13827483031&ref=vm_uk_pr_ao_pd10t"
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:24.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:26.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:28.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:30.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:32.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:34.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:36.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:04:38.476Z
EXTINF:2.000,3648366870f93cffb39288a3cb7e2e2c-03-04-2019-00.00.03
ghost
on 16 Mar 2019
The playlist is indeed different for the HLS ad segments vs live stream segments. I need to download the playlist a few times to ensure it includes both ad and live stream segments.
Note that the live segments are prefixed with #EXTINF:2.000,live while the ad segments aren't. This seems like something they could easily change though.
streamlink --version
streamlink 1.0.0
streamlink --stream-url twitch.tv/tfue
https://video-weaver.syd01.hls.ttvnw.net/v1/playlist/CrYDff5aYKA19XXRE_GyftQTF1U5azuypA4VpL6zldptf-iPq1ayyCuU7496LQ1KmBf9-isCSbuLu73Xmc_Cdz2GE_dKAsCDRZ5XsUO_H4lZQpV30H7ypoEuA7O1i7R4WC7XAgIwxtCbMlF_Knp0iZmBYZeJuORZEqbygOd5C6yPaR2CGCxUMdVXtTJhgIptnDgtHwlBvGoUBHziRZmXDvNMD8wzRjsoxM2caCBRy7fQme8OWg_FZA-AALhf1QUxhu536WILF0WVw3oL2M5tIljQIq-tJIrrsYH5FqD0qbc5D27DLOKHFBWdmQk6jB_59-jWwfDE9G-7lbBZrkZDQ2R5rEhDjDkfz8W7dopgDKIs2Cz8TrB04HBzG5_Ywi4uFV7AdKGacc_yQkvabh8f6yG2A2hkIoPiuqajvEmk-0_cIFKfR5uQd_en1VbWRGCJtZLLy47X6Yqn21Ph1-rP3Wlp8UdxzPatdRTCZVWGuyWK84V9nkyafVQzf49HfWSamyVA64FMnXyhLqsjvv9m5lxj7hyDmmhy1dLkHcuPEgADcAyc-_segYYFuZ4TRoOT0WPkiOIUTKLXEhA8UPY5GtOddTEKwdQHeITJGgwCeDSchjJvNannfmU.m3u8
```#EXTM3U
EXT-X-VERSION:3
EXT-X-TARGETDURATION:5
EXT-X-MEDIA-SEQUENCE:0
EXT-X-TWITCH-ELAPSED-SECS:14632.000
EXT-X-TWITCH-TOTAL-SECS:14657.164
EXT-X-DATERANGE:ID="stitched-ad-1552713489-15163999993",CLASS="twitch-stitched-ad",START-DATE="2019-03-16T05:18:09.474Z",DURATION=15.164,X-TV-TWITCH-AD-POD-POSITION="0",X-TV-TWITCH-AD-URL="https://www.moosetoys.com/brand/fortnite/",X-TV-TWITCH-AD-ROLL-TYPE="PREROLL",X-TV-TWITCH-AD-POD-LENGTH="1"
EXT-X-DISCONTINUITY
EXT-X-SCTE35-OUT:URL="https://www.moosetoys.com/brand/fortnite/"
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:09.474Z
EXTINF:2.002,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:11.475999999Z
EXTINF:2.002,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:13.477999998Z
EXTINF:2.002,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:15.479999997Z
EXTINF:2.002,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:17.481999996Z
EXTINF:2.002,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:19.483999995Z
EXTINF:2.002,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:21.485999994Z
EXTINF:2.002,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:23.487999993Z
EXTINF:1.150,87d22d0b208d6a47c3bba6f412f7fb43-03-04-2019-05.03.22
EXT-X-DISCONTINUITY
EXT-X-SCTE35-IN
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:23.474Z
EXTINF:2.000,live
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:25.474Z
EXTINF:2.000,live
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:27.474Z
EXTINF:2.000,live
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:29.474Z
EXTINF:2.000,live
EXT-X-PROGRAM-DATE-TIME:2019-03-16T05:18:31.474Z
EXTINF:2.000,live
noadsthx
on 16 Mar 2019
Thanks, I also just got an ad. Looks like the playlist containing the EXT-X-DISCONTINUITY tag is the one with ads (and the following ones until the next tag). I wonder if those could simply be dropped...
bastimeyer
on 16 Mar 2019
According to this chrome extension the ad segments are marked as advertisements using the SCTE-35 flag
Edit: A better source for the SCTE-35 messages in HLS might be Amazons own documentation on it here.
Thus the beginning of the ad should be marked with SCTE35-OUT and the end with SCTE35-IN
skulblakka
on 16 Mar 2019
I can confirm this.
I just had a "twitch prime" ad for the first time today when I launched a stream.
vohzi
on 16 Mar 2019
Some more info:
While testing with Tfue's stream, Twitch isn't currently showing me any preroll ads in my browser while logged in to my Twitch account. I can consistently get preroll ads while opening his stream in private browsing mode though. It seems that Twitch may have saved a flag server-side to prevent showing me ads for some period of time.
Streamlink consistently displays the preroll ads on Tfue's stream every time. Using Streamlink OAuth to Twitch doesn't seem to help at all there.
Testing with other streams is inconsistent, Tfue's is one of the few i've found which will consistently display the preroll ad in Streamlink, it's probably a good candidate for testing while he remains live.
I made a small hacky modification to the low latency test plugin which prevents preroll ads from being shown in Streamlink, I still get an ad-length delay when opening the stream though so it's not particularly helpful.
Change line 378 from:
elif line.startswith("#EXTINF"):
To:
elif re.match("#EXTINF:[0-9].[0-9]*,live", line):
Make sure you keep the spaces preceding the line.
Note: Might break stuff.
Edit: Above change does break the stream after downloading about 16 segments. Left in case someone wants to expand on it.
I fear that Twitch will refuse to send you the live stream segments until the time when the ad would be complete and that there may not be a way around it.
noadsthx
on 16 Mar 2019
A simple solution that works is to block the ip serving ads. Use wireshark and block the entire subnet.
R3dF0xFF
on 16 Mar 2019
Changing chrome user agent to "Blackberry --9900" prevents ads from appearing.
887ryui
on 16 Mar 2019
Changing chrome user agent to "Blackberry --9900" prevents ads from appearing.
How does one do this in streamlink ?
vohzi
on 16 Mar 2019
Don't know if it's related but the Alternative Player For Twitch extension for Chrome and FF just started showing ads too (as of last night). Seems Twitch have changed something their end.
MancV21
on 16 Mar 2019
I'll comment here as there isn't an issue open on the uBlockOrigin repo and I don't have a reddit account.
The https://api.twitch.tv/api/channels/XXXXXXXX/access_token? request is what determines if server side ads are delivered. A regular request/response by a browser without an adblocker will look as follows:
https://api.twitch.tv/api/channels/quin69/access_token?need_https=true&oauth_token&platform=web&player_backend=mediaplayer&player_type=site
{"token":"{\"adblock\":false,\"authorization\":{\"forbidden\":false,\"reason\":\"\"},\"blackout_enabled\":false,\"channel\":\"quin69\",\"channel_id\":56649026,\"chansub\":{\"restricted_bitrates\":[],\"view_until\":REDACTED},\"ci_gb\":false,\"geoblock_reason\":\"\",\"device_id\":null,\"expires\":REDACTED,\"game\":\"Path of Exile\",\"hide_ads\":false,\"https_required\":true,\"mature\":false,\"partner\":false,\"platform\":\"web\",\"player_type\":\"site\",\"private\":{\"allowed_to_view\":true},\"privileged\":false,\"server_ads\":true,\"show_ads\":true,\"subscriber\":false,\"turbo\":false,\"user_id\":null,\"user_ip\":\"REDACTED\",\"version\":2}","sig":"REDACTED","mobile_restricted":false}
The token/sig are then used as part of the m3u8 request. Notice that in the response the 'server_ads' param is 'true'. If you modify the 'platform' param in the request to be something like '_' the response now has 'server_ads' set to 'false' and ads are no longer shown.
https://api.twitch.tv/api/channels/quin69/access_token?need_https=true&oauth_token=&platform=_&player_backend=mediaplayer
{"token":"{\"adblock\":false,\"authorization\":{\"forbidden\":false,\"reason\":\"\"},\"blackout_enabled\":false,\"channel\":\"quin69\",\"channel_id\":56649026,\"chansub\":{\"restricted_bitrates\":[],\"view_until\":REDACTED},\"ci_gb\":false,\"geoblock_reason\":\"\",\"device_id\":null,\"expires\":REDACTED,\"game\":\"Path of Exile\",\"hide_ads\":false,\"https_required\":true,\"mature\":false,\"partner\":false,\"platform\":\"_\",\"player_type\":null,\"private\":{\"allowed_to_view\":true},\"privileged\":false,\"server_ads\":false,\"show_ads\":true,\"subscriber\":false,\"turbo\":false,\"user_id\":null,\"user_ip\":\"REDACTED\",\"version\":2}","sig":"REDACTED","mobile_restricted":false}
Last time there were changes to the way they served ads they quickly made additional changes so it's likely that this method wont work for long.
Here is a test url which can be used with uBlockOrigin's userResourcesLocation (which changes the platform to '_' as mentioned above) https://gist.githubusercontent.com/pixeltris/1338ad540175499b90b3dc245de663be/raw/58154403783563f0370dd7a39bc1517c39a81c7c/gistfile1.txt
pixeltris
on 16 Mar 2019
The ublock issue is here https://github.com/uBlockOrigin/uAssets/issues/5138
Qrokqt
on 16 Mar 2019
@vohzi
You can change HTTP headers via --http-header "key=value".
Setting the User-Agent to Blackberry --9900 does not prevent ads from being injected into the stream. I don't think they will check the User-Agent string, since it can easily be faked.
@pixeltris
Adding the platform=_ GET parameter to the access_token API endpoint call seems to be working. But yeah, that's something they could fix very easily.
If anyone wants to try it, see this diff:
diff --git a/src/streamlink/plugins/twitch.py b/src/streamlink/plugins/twitch.py
index 410a22b6..17ce4e0b 100644
--- a/src/streamlink/plugins/twitch.py
+++ b/src/streamlink/plugins/twitch.py
@@ -222,7 +222,7 @@ class TwitchAPI(object):
# Private API calls
def access_token(self, endpoint, asset, **params):
- return self.call("/api/{0}/{1}/access_token".format(endpoint, asset), **params)
+ return self.call("/api/{0}/{1}/access_token".format(endpoint, asset), **dict(platform="_", **params))
def token(self, **params):
return self.call("/api/viewer/token", **params)
The SureStream page says it is only available on desktop devices. Might be the reason why changing the platform parameter disables ad injection.
skulblakka
on 16 Mar 2019
This isn't just limited to desktop devices. I am encountering ads using Pocket Plays as well as of this morning.
gravyboat
on 16 Mar 2019
If anyone wants to try it, see this diff:
so far so good. no pre-rolls across multiple streams of varying sizes.
edit: no streamer triggered ads either.
This isn't just limited to desktop devices. I am encountering ads using Pocket Plays as well as of this morning.
if i load a pre-fix streamlink extracted url into safari for ios, ads will play. adguard pro for ios, however, still works for the official twitch app (forcing a system wide filtered dns using a local vpn). from memory, system level blocking works a similar way on android - my guess is if you were to do the same with the official android twitch app, you won't see ads. both apps might be passing along their respective platform strings - with dns/vpn intercepting the ad requests - while pocket plays is relying on similar methodology to streamlink. or maybe not, but worth a test.
ghost
on 16 Mar 2019
Can
@vohzi
You can change HTTP headers via--http-header "key=value".
Setting theUser-AgenttoBlackberry --9900does not prevent ads from being injected into the stream. I don't think they will check the User-Agent string, since it can easily be faked.@pixeltris
Adding theplatform=_GET parameter to theaccess_tokenAPI endpoint call seems to be working. But yeah, that's something they could fix very easily.
If anyone wants to try it, see this diff:diff --git a/src/streamlink/plugins/twitch.py b/src/streamlink/plugins/twitch.py index 410a22b6..17ce4e0b 100644 --- a/src/streamlink/plugins/twitch.py +++ b/src/streamlink/plugins/twitch.py @@ -222,7 +222,7 @@ class TwitchAPI(object): # Private API calls def access_token(self, endpoint, asset, **params): - return self.call("/api/{0}/{1}/access_token".format(endpoint, asset), **params) + return self.call("/api/{0}/{1}/access_token".format(endpoint, asset), **dict(platform="_", **params)) def token(self, **params): return self.call("/api/viewer/token", **params)
Can you explain how to apply that change so I can test it? Thanks
MancV21
on 16 Mar 2019
It seems that the workarounds were patched? Getting ads inserted even after using platform="_", "platform=_" and platform=_
I don't mind seeing ads but they are all causing the stream to skip content to a few seconds ahead. Twitch is really burying themselves here.
Satoshi64
on 18 Mar 2019
Are you running the latest dev version?
streamlink 1.0.0+38.g9ae6756
I'm not getting ads on any channel.
Getting ads inserted even after using
platform="_","platform=_"andplatform=_
What do you mean? This looks like you're trying to set CLI parameters, which doesn't make any sense.
bastimeyer
on 18 Mar 2019
I was also kind of able to get rid of the ads by skipping all the files between the SCTE-35 markers. However the playlist will not contain enough regular segments for a bit. For me the normal stream continued after about 15 seconds which is probably still shorter than the actual ad is.
skulblakka
on 18 Mar 2019
I installed streamlink-1.0.0-20190317 from here, and I still see ads. The installer says 1.0.0+38.g9ae6756 so I assume it's the correct one.
sfkpmr
on 18 Mar 2019
@sfkpmr Please completely remove any old installs first. You might still be using an older version which is still installed on your system or the installer might not have updated all of the files (which is a known issue). Please provide a proper debug log (--loglevel debug)
bastimeyer
on 19 Mar 2019
I just did a clean install for the first time and I'm getting ads.
位 streamlink --loglevel debug
[cli][debug] OS: Windows 10
[cli][debug] Python: 3.6.6
[cli][debug] Streamlink: 1.0.0
[cli][debug] Requests(2.21.0), Socks(1.6.7), Websocket(0.54.0)
usage: streamlink [OPTIONS] <URL> [STREAM]
Use -h/--help to see the available options or read the manual at https://streamlink.github.io
Could I get some instructions regarding what to do to disable ads?
Thanks.
otmeek
on 19 Mar 2019
@bastimeyer I was using the headers option. It seems that github cuts out the _ inside "".
Satoshi64
on 19 Mar 2019
@bastimeyer Correct, I was stuck on an old version. Tested a number of streams, and no pre-rolls yet! :)
For some reason the old files didn't seem to be affected at all. Had to manually delete them and reinstall.
sfkpmr
on 19 Mar 2019
@otmeek You are not using the latest development version, you are using the latest stable release (1.0.0)
@Satoshi64 It's regular markdown. Use `text` to format inline code. But regarding the parameter, it's not an HTTP header, but an HTTP GET parameter of a certain API request. You can't use any of Streamlink's CLI options to set this. Just upgrade Streamlink or replace the plugin file in order to make it work.
I will lock this thread now, since the the current ads workaround is still working and the issue solved. If you're having troubles getting it to work, please uninstall Streamlink and install the latest development release. More information can be found here:
https://streamlink.github.io/latest/install.html
https://streamlink.github.io/latest/install.html#source-code
https://streamlink.github.io/latest/install.html#windows-binaries
bastimeyer
on 19 Mar 2019
Related issues
TheSneakySniper
路
55Comments
bastimeyer
路
72Comments
gimli520
路
106Comments
cdrage
路
43Comments
jacob1218
路
42Comments
Most helpful comment
@vohzi
You can change HTTP headers via
--http-header "key=value".Setting the
User-AgenttoBlackberry --9900does not prevent ads from being injected into the stream. I don't think they will check the User-Agent string, since it can easily be faked.@pixeltris
Adding the
platform=_GET parameter to theaccess_tokenAPI endpoint call seems to be working. But yeah, that's something they could fix very easily.If anyone wants to try it, see this diff: