Straight.el: Regression prevents straight from resolving dependencies

Created on 10 Feb 2020  ·  2Comments  ·  Source: raxod502/straight.el

What's wrong

Straight fails to resolve (and thus, install) dependencies due to https://github.com/raxod502/straight.el/commit/260b388a96bb20af430e2935c92529a8bbde14cc. This new regexp leaves the cursor on the colon whitespace just after the colon in the Package-Requires: header. The old regexp would place the cursor directly on the opening parentheses of the package list (assuming the header is well-formed).

Then (looking-at "(") returns nil, and no dependencies are computed.

The following works around it:

                  (let ((case-fold-search t))
                    (re-search-forward "^;; *Package-Requires *:"))
-                 (when (looking-at "(")
+                 (when (looking-at " *(")
                    (straight--process-dependencies
                     (read (current-buffer)))))))))

Relevant to: https://github.com/hlissner/doom-emacs/issues/2517

EDIT: Corrected my diagnosis.

Version information

  • Emacs version: 26.3 (on Doom Emacs)
  • Operating system: NixOS
bug dependencies regression

Most helpful comment

This should be fixed by https://github.com/raxod502/straight.el/commit/370059b2769a8100a03339a7ef245025ba55f6ea. I am very sorry for the inconvenience.

All 2 comments

This should be fixed by https://github.com/raxod502/straight.el/commit/370059b2769a8100a03339a7ef245025ba55f6ea. I am very sorry for the inconvenience.

No worries! I can confirm that the fix resolves this. Thanks for the prompt response (and for this fantastic package!)

Was this page helpful?
0 / 5 - 0 ratings