Storybook: Storybook requires installing webpack which makes no sense

Created on 5 Apr 2020  Â·  5Comments  Â·  Source: storybookjs/storybook

Describe the bug
Storybook has a peerDependency on babel-loader which has a peerDependency on webpack => 2. The result is that storybook requires installing webpack as a dependency even though it's absolutely not needed.

â–¶ yarn
➤ YN0000: ┌ Resolution step
➤ YN0002: │ test@workspace:library/test doesn't provide webpack@>=2 requested by babel-loader@npm:8.1.0
➤ YN0000: └ Completed in 10.43s
➤ YN0000: ┌ Fetch step

Expected behavior
Storybook should not have a (transitive) peerDependency on webpack.

Additional context
I'm trying out storybook 6.0.0-alpha.30 with yarn2. Yarn complains about the unsatisfied peerDependency.

dependencies question / support

All 5 comments

cc @gaetanmaisse

Hmmm I see, it appears because I fixed some missing transitive peer dependencies (great post about this: https://dev.to/arcanis/implicit-transitive-peer-dependencies-ed0) and as @storybook/core has a peerDependency on babel-loader almost every package has it too 🙃

However, it looks like babel-loader is now a regular dependency of @storybook/core(https://github.com/storybookjs/storybook/commit/997c224d5528235280ced846bdef4cc148a9514b#diff-d56180255ddcda2cd5bc64ca50a485f1R51) so we can maybe clean its usage 🤔 . I will discuss this with @ndelangen today.

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

This is still an issue I believe.

https://github.com/storybookjs/storybook/pull/10613 has been merged, so as soon 6.0.0-beta.1 will be out this issue should be fixed, as babel-loader will not be a peerDeps of @storybook/core anymore.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

EdenTurgeman picture EdenTurgeman  Â·  81Comments

maraisr picture maraisr  Â·  119Comments

bpeab picture bpeab  Â·  70Comments

43081j picture 43081j  Â·  61Comments

ChucKN0risK picture ChucKN0risK  Â·  74Comments