Storybook: [lib/api] Move @types/reach__router into devDependencies?

Created on 10 Mar 2020  路  3Comments  路  Source: storybookjs/storybook

Is your feature request related to a problem? Please describe.
I'm using Storybook with non-React JSX factory.
Since @storybook/api depends on @types/reach__router and it also brings @types/react, which introduces a global pollution of JSX namespace (declare global { namespace JSX { ... } }).

Describe the solution you'd like
Moving @types/reach__router from dependencies to devDependencies looks fine for me.
(Or is there a fair reason to declare it as a runtime dependency?)

https://github.com/storybookjs/storybook/blob/1af0458de81978964500a7a3d75cd10c0b0df4b8/lib/api/package.json#L37

Describe alternatives you've considered
Nothing.

Are you able to assist bring the feature to reality?
Yes.
If this change looks fine, I'm glad to open a pull request.

Additional context

Other @types/* packages are defined in devDependencies.

https://github.com/storybookjs/storybook/blob/1af0458de81978964500a7a3d75cd10c0b0df4b8/lib/api/package.json#L51-L53

react dependencies help wanted inactive typescript

All 3 comments

We re-export some types from reach-router. If we move them, our packages break for typescript users, because the typings we refer to would be missing.

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Gongreg picture Gongreg  路  58Comments

bpeab picture bpeab  路  70Comments

maraisr picture maraisr  路  119Comments

p3k picture p3k  路  61Comments

tycho01 picture tycho01  路  76Comments