Storybook: [@storybook/theming] dark theming on test fail panel is incorrect

Created on 14 Feb 2020  路  4Comments  路  Source: storybookjs/storybook

Describe the bug
official dark theming on test fail panel is incorrect.

To Reproduce
Steps to reproduce the behavior:

  1. setup addon jest
  2. write a fail spec
  3. open the tests panel
  4. See error

Expected behavior
color contrast for best readability.

Screenshots
image

Code snippet

~~~js
// .storybook/manager.js
import { addons } from '@storybook/addons'
import { themes } from '@storybook/theming'

addons.setConfig({
theme: themes.dark,
})
~~~

~~~js
// .storybook/preview.js
import { addParameters, addDecorator } from '@storybook/react'
import { withTests } from '@storybook/addon-jest'

import results from './jest-test-results.json'

addDecorator(withTests({ results }))

addParameters({
jest: ['spec.tsx'],
})
~~~

jest bug theming

All 4 comments

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@rwu823 any interest in contributing a fix for this?

@shilman yeah I'll try.

I tried the latest version 6.0.0-alpha.30 is worked fine. close it.

image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dmmarmol picture dmmarmol  路  57Comments

moimikey picture moimikey  路  67Comments

Olian04 picture Olian04  路  78Comments

bpeab picture bpeab  路  70Comments

joeruello picture joeruello  路  79Comments