Storybook: isFullscreen: false option not working

Created on 23 Oct 2019  路  13Comments  路  Source: storybookjs/storybook

Describe the bug
In the config.js addParameters function, if I set isFullscreen: true and open the webpage, it is fullscreen on startup. But if I set isFullscreen: false and open the webpage again, it is still full-screen on startup.

To Reproduce

  1. Set isFullscreen: true, open the webpage,
  2. Close the webpage or stop the server
  3. Set isFullscreen: false, open the webpage

Expected behavior
I should see storybook not in full-screen mode

System:

Environment Info:

  System:
    OS: Windows 10
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
  Binaries:
    Node: 10.15.0 - C:\Program Files\nodejs\node.EXE
    npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
bug good first issue help wanted needs reproduction ui

All 13 comments

I can work on this issue. Can anyone guide me please?
I'm going to contribute here first time.

@shilman, that's related to https://github.com/storybookjs/storybook/issues/5857, isn't it?

Is this issue this open? i wish to work on it.

@ahmedkhan1 yes please!

I'm a first timer wanna contribute is it still available
i'll do my best to remove the bug

Hello, is anyone working on this?

not that i know of

Great, I will take this on. I have downloaded storybook now and messing around with the features. I will try and reproduce the error on my machine. I am running on a mac, hopefully this isn't just a windows thing.

Interesting, I can't reproduce this error. I am running on a Mac. When I add the manager.js file and go from true to false after closing the window I see the that side nav is visible. When set to true the side panel is not visible.
Screen Shot 2020-05-26 at 9 42 59 PM
Screen Shot 2020-05-26 at 9 43 17 PM

Hello, Is anyone working on this issue?
Can I work on this?

Hi! Can I work on this issue or help someone in this?, this will be my first contribution. Is anybody working on this ?

Hi, is it still relevant?
I can't reproduce this, it works just fine.

@shilman WDYT?

Thanks @almogbhl Closing this until somebody provides a repro

Was this page helpful?
0 / 5 - 0 ratings