Storybook: @storybook/angular & @storybook/addons require node types

[sod]

Can't find it in the source code, but the published @storybook/angular & @storybook/addons version 5.2.3 types require node types:

That conflicts with client code, e.g. we see lots of:

Error:(10, 9) TS2322: Type 'Timeout' is not assignable to type 'number'.

Because the node.js setTimeout definition returns Timeout and the dom implementation returns number. Is that reference to node.js really required? Given that much of the code also runs in the browser, node.js types are kind of misleading anyway.

[sod]

The workaround I use right now is setting this in tsconfig.json compilerOptions:

        "typeRoots": [
            "@types",
            "../node_modules/@types"
        ]

and create an empty @types/node/index.d.ts file. When typescript tries to resolve the /// <reference types="node" />, it'll grab the empty definition instead of the one installed in node_modules/@types.

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[aaronjensen]

This is a pretty important one, it just bit us as well.

[kroeder]

The client and server code of app/angular shares the same tsconfig with types: ['node']

Maybe we can use the tripple-slash reference directly where they are needed and remove node from the tsconfig 🤔
Hopefully the same works for @storybook/addon

[aaronjensen]

I'm guessing its the uses of the global NodeModule:

https://github.com/storybookjs/storybook/blob/7ac1cab8d5039c35e0aa8dd92497ab16b75ae9bd/lib/addons/src/types.ts#L97

and

https://github.com/storybookjs/storybook/blob/5770c8e6357910f489a942a87cc579a3188db136/app/react/src/client/preview/index.ts#L13

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[aaronjensen]

Still an issue.

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[aaronjensen]

Still an issue, unless it's been addressed? Someone is assigned to it. It's probably not a tough issue to address.

[shilman]

@aaronjensen do you want to take a crack at this?

[ndelangen]

Maybe @gaetanmaisse knows how to solve this?

[aaronjensen]

I think I have a fix. Will submit soon.

[aaronjensen]

Try out https://github.com/storybookjs/storybook/pull/9213

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[aaronjensen]

This was fixed.