Storybook: broken build on version 5.2.2

Created on 7 Oct 2019  ·  5Comments  ·  Source: storybookjs/storybook

Describe the bug
Build is broken after updated to version 5.2.2

To Reproduce

  1. Upgrade storybook to version 5.2.2
  2. run storybook

Expected behavior

Build runs correctly

Code snippets

❯ yarn storybook
yarn run v1.19.0
$ yarn storybook:js-config && start-storybook -p 9009 -s public
$ node scripts/storybook-config.js
info @storybook/react v5.2.2
info
info => Loading static files from: /Users/pedro/dev/ga-frontend-go/public .
info => Loading presets
info => Loading presets
info => Loading custom addons config.
info => Using default Webpack setup.
info => Loading create-react-app config.
14% building 38/87 modules 49 active ...v/ga-frontend-go/node_modules/react/cjs/react.development.js
25% building 126/182 modules 56 active ...edro/dev/ga-frontend-go/src/components/WidgetGrid/index.js
30% building 171/229 modules 58 active ...rontend-go/node_modules/core-js/internals/native-symbol.js
30% building 172/229 modules 57 active ...rontend-go/node_modules/core-js/internals/native-symbol.js
56% building 389/424 modules 35 active .../pedro/dev/ga-frontend-go/node_modules/lodash/_castPath.js
57% building 395/440 modules 45 active .../dev/ga-frontend-go/node_modules/lodash/_initCloneByTag.js
57% building 396/442 modules 46 active ...ga-frontend-go/node_modules/core-js/internals/iterators.js
57% building 398/443 modules 45 active ...s/pedro/dev/ga-frontend-go/node_modules/es-abstract/es5.js
66% building 576/614 modules 38 active ...ro/dev/ga-frontend-go/node_modules/lodash/_assocIndexOf.js
67% building 612/638 modules 26 active .../node_modules/@emotion/memoize/dist/memoize.browser.esm.js
68% building 872/894 modules 22 active .../ga-frontend-go/src/components/FormControlLabel/styles.tsx
68% building 911/939 modules 28 active ...edro/dev/ga-frontend-go/src/components/Chart/Axis/index.js
68% building 1094/1118 modules 24 active ...-frontend-go/node_modules/axios/lib/core/enhanceError.js
68% building 1662/1692 modules 30 active ...pedro/dev/ga-frontend-go/src/components/Layout/index.tsx
68% building 1663/1692 modules 29 active ...pedro/dev/ga-frontend-go/src/components/Layout/index.tsx
69% building 1664/1692 modules 28 active ...pedro/dev/ga-frontend-go/src/components/Layout/index.tsx
68% building 1667/1705 modules 38 active ...nd-go/node_modules/@material-ui/system/esm/typography.js
68% building 1668/1705 modules 37 active ...nd-go/node_modules/@material-ui/system/esm/typography.js
69% building 1749/1773 modules 24 active .../dev/ga-frontend-go/src/components/Dropdown/Dropdown.tsx
69% building 1751/1776 modules 25 active ...-frontend-go/node_modules/css-loader/dist/runtime/api.js
69% building 1860/1885 modules 25 active ...end-go/node_modules/react-markdown/lib/react-markdown.js
69% building 1863/1887 modules 24 active ...ext/node_modules/@babel/runtime/helpers/inheritsLoose.js
69% building 2005/2017 modules 12 active ...re/node_modules/@emotion/cache/dist/cache.browser.esm.js
webpack built d2d51ff1b459444a0c53 in 31750ms
✖ ｢wdm｣: Hash: d2d51ff1b459444a0c53
Version: webpack 4.39.1
Time: 31750ms
Built at: 07/10/2019 07:37:07
                                               Asset       Size        Chunks                    Chunk Names
                                 asset-manifest.json   1.65 KiB                [emitted]
                                         iframe.html   3.24 KiB                [emitted]
                 main.d2d51ff1b459444a0c53.bundle.js   1.37 MiB          main  [emitted]  [big]  main
             main.d2d51ff1b459444a0c53.bundle.js.map    689 KiB          main  [emitted]         main
         runtime~main.d2d51ff1b459444a0c53.bundle.js   31.2 KiB  runtime~main  [emitted]         runtime~main
     runtime~main.d2d51ff1b459444a0c53.bundle.js.map   32.3 KiB  runtime~main  [emitted]         runtime~main
static/media/annotations-popover-header.c6922cf3.svg   2.63 KiB                [emitted]
            static/media/cohorts-points.407d9615.svg   1.51 KiB                [emitted]
                   static/media/cohorts.cee48fa4.svg  777 bytes                [emitted]
        static/media/config-empty-state.678113e2.svg   4.23 KiB                [emitted]
                   static/media/funnels.fe6037f4.svg    1.3 KiB                [emitted]
   static/media/gameanalytics-with-text.71fc951c.svg   7.57 KiB                [emitted]
             static/media/gameanalytics.0c11ca19.svg   1.02 KiB                [emitted]
                static/media/left-arrow.e80fc42d.svg   1.16 KiB                [emitted]
                      static/media/logo.99bce993.png    140 KiB                [emitted]
            static/media/remote-configs.5b4855ca.svg   1.52 KiB                [emitted]
               static/media/right-arrow.a1425630.svg   1.16 KiB                [emitted]
                  static/media/segments.62c9b2af.svg   1.35 KiB                [emitted]
                  static/media/timezone.03ce595c.svg   1.05 KiB                [emitted]
         vendors~main.d2d51ff1b459444a0c53.bundle.js   8.52 MiB  vendors~main  [emitted]  [big]  vendors~main
     vendors~main.d2d51ff1b459444a0c53.bundle.js.map   7.49 MiB  vendors~main  [emitted]         vendors~main
Entrypoint main [big] = runtime~main.d2d51ff1b459444a0c53.bundle.js runtime~main.d2d51ff1b459444a0c53.bundle.js.map vendors~main.d2d51ff1b459444a0c53.bundle.js vendors~main.d2d51ff1b459444a0c53.bundle.js.map main.d2d51ff1b459444a0c53.bundle.js main.d2d51ff1b459444a0c53.bundle.js.map
[0] multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true 64 bytes {main} [built]
[./.storybook/GATheme.js] 282 bytes {main} [built]
[./.storybook/config.js] 2.11 KiB {main} [built]
[./node_modules/@material-ui/core/esm/Card/index.js] 33 bytes {vendors~main} [built]
[./node_modules/@material-ui/core/esm/CardContent/index.js] 40 bytes {vendors~main} [built]
[./node_modules/@material-ui/core/esm/styles/index.js] 580 bytes {vendors~main} [built]
[./node_modules/@material-ui/styles/esm/index.js] 1.76 KiB {vendors~main} [built]
[./node_modules/@storybook/core/dist/server/common/polyfills.js] 120 bytes {vendors~main} [built]
[./node_modules/@storybook/core/dist/server/preview/globals.js] 93 bytes {vendors~main} [built]
[./node_modules/@storybook/core/node_modules/regenerator-runtime/runtime.js] 23 KiB {vendors~main} [built]
[./node_modules/@storybook/core/node_modules/webpack/buildin/harmony-module.js] (webpack)/buildin/harmony-module.js 573 bytes {vendors~main} [built]
[./node_modules/@storybook/core/node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {vendors~main} [built]
[./node_modules/@storybook/react/dist/client/index.js] 1.39 KiB {vendors~main} [built]
[./node_modules/airbnb-js-shims/index.js] 40 bytes {vendors~main} [built]
[./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true] 7.68 KiB {vendors~main} [built]
    + 2544 hidden modules

ERROR in ./node_modules/@storybook/react/dist/client/preview/index.js
Module not found: Error: Can't resolve '@storybook/core/client' in '/Users/pedro/dev/ga-frontend-go/node_modules/@storybook/react/dist/client/preview'
 @ ./node_modules/@storybook/react/dist/client/preview/index.js 12:14-47
 @ ./node_modules/@storybook/react/dist/client/index.js
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true
Child HtmlWebpackCompiler:
                          Asset      Size               Chunks  Chunk Names
    __child-HtmlWebpackPlugin_0  29.9 KiB  HtmlWebpackPlugin_0  HtmlWebpackPlugin_0
    Entrypoint HtmlWebpackPlugin_0 = __child-HtmlWebpackPlugin_0
    [./node_modules/@storybook/core/node_modules/html-webpack-plugin/lib/loader.js!./node_modules/@storybook/core/dist/server/templates/index.ejs] 2.12 KiB {HtmlWebpackPlugin_0} [built]

WARN Broken build, fix the error above.
WARN You may need to refresh the browser.

webpack building...
webpack built 7084375061a018751b20 in 8302ms
✖ ｢wdm｣: Hash: 7084375061a018751b20
Version: webpack 4.39.1
Time: 8302ms
Built at: 07/10/2019 07:37:17
                                               Asset       Size        Chunks                    Chunk Names
                                 asset-manifest.json   1.71 KiB                [emitted]
                d2d51ff1b459444a0c53.hot-update.json   54 bytes                [emitted]
                                         iframe.html   3.32 KiB                [emitted]
                 main.7084375061a018751b20.bundle.js   1.37 MiB          main  [emitted]  [big]  main
             main.7084375061a018751b20.bundle.js.map    692 KiB          main  [emitted]         main
         runtime~main.7084375061a018751b20.bundle.js   31.2 KiB  runtime~main  [emitted]         runtime~main
     runtime~main.7084375061a018751b20.bundle.js.map   32.3 KiB  runtime~main  [emitted]         runtime~main
static/media/annotations-popover-header.c6922cf3.svg   2.63 KiB
            static/media/cohorts-points.407d9615.svg   1.51 KiB
                   static/media/cohorts.cee48fa4.svg  777 bytes
        static/media/config-empty-state.678113e2.svg   4.23 KiB
                   static/media/funnels.fe6037f4.svg    1.3 KiB
   static/media/gameanalytics-with-text.71fc951c.svg   7.57 KiB
             static/media/gameanalytics.0c11ca19.svg   1.02 KiB
                static/media/left-arrow.e80fc42d.svg   1.16 KiB
                      static/media/logo.99bce993.png    140 KiB
            static/media/remote-configs.5b4855ca.svg   1.52 KiB
               static/media/right-arrow.a1425630.svg   1.16 KiB
                  static/media/segments.62c9b2af.svg   1.35 KiB
                  static/media/timezone.03ce595c.svg   1.05 KiB
         vendors~main.7084375061a018751b20.bundle.js   8.52 MiB  vendors~main  [emitted]  [big]  vendors~main
     vendors~main.7084375061a018751b20.bundle.js.map   7.49 MiB  vendors~main  [emitted]         vendors~main
     vendors~main.d2d51ff1b459444a0c53.hot-update.js   41.2 KiB  vendors~main  [emitted]         vendors~main
 vendors~main.d2d51ff1b459444a0c53.hot-update.js.map   8.93 KiB  vendors~main  [emitted]         vendors~main
Entrypoint main [big] = runtime~main.7084375061a018751b20.bundle.js runtime~main.7084375061a018751b20.bundle.js.map vendors~main.7084375061a018751b20.bundle.js vendors~main.d2d51ff1b459444a0c53.hot-update.js vendors~main.7084375061a018751b20.bundle.js.map vendors~main.d2d51ff1b459444a0c53.hot-update.js.map main.7084375061a018751b20.bundle.js main.7084375061a018751b20.bundle.js.map
[0] multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true 64 bytes {main}
[./.storybook/GATheme.js] 282 bytes {main}
[./.storybook/config.js] 2.11 KiB {main}
[./node_modules/@material-ui/core/esm/Card/index.js] 33 bytes {vendors~main}
[./node_modules/@material-ui/core/esm/CardContent/index.js] 40 bytes {vendors~main}
[./node_modules/@material-ui/core/esm/styles/index.js] 580 bytes {vendors~main}
[./node_modules/@material-ui/styles/esm/index.js] 1.76 KiB {vendors~main}
[./node_modules/@storybook/core/dist/server/common/polyfills.js] 120 bytes {vendors~main}
[./node_modules/@storybook/core/dist/server/preview/globals.js] 93 bytes {vendors~main}
[./node_modules/@storybook/core/node_modules/regenerator-runtime/runtime.js] 23 KiB {vendors~main}
[./node_modules/@storybook/core/node_modules/webpack/buildin/harmony-module.js] (webpack)/buildin/harmony-module.js 573 bytes {vendors~main}
[./node_modules/@storybook/core/node_modules/webpack/buildin/module.js] (webpack)/buildin/module.js 497 bytes {vendors~main}
[./node_modules/@storybook/react/dist/client/index.js] 1.39 KiB {vendors~main}
[./node_modules/airbnb-js-shims/index.js] 40 bytes {vendors~main}
[./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true] 7.68 KiB {vendors~main}
    + 2544 hidden modules

ERROR in ./node_modules/@storybook/react/dist/client/preview/index.js
Module not found: Error: Can't resolve '@storybook/core/client' in '/Users/pedro/dev/ga-frontend-go/node_modules/@storybook/react/dist/client/preview'
 @ ./node_modules/@storybook/react/dist/client/preview/index.js 12:14-47
 @ ./node_modules/@storybook/react/dist/client/index.js
 @ ./.storybook/config.js
 @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js ./node_modules/webpack-hot-middleware/client.js?reload=true&quiet=true

System:

Environment Info:

  System:
    OS: macOS Mojave 10.14.6
    CPU: (4) x64 Intel(R) Core(TM) i5-7360U CPU @ 2.30GHz
  Binaries:
    Node: 12.11.1 - /usr/local/bin/node
    Yarn: 1.19.0 - /usr/local/bin/yarn
    npm: 6.11.3 - /usr/local/bin/npm
  Browsers:
    Chrome: 77.0.3865.90
    Firefox: 69.0.1
    Safari: 13.0.1
  npmPackages:
    @storybook/addon-actions: ^5.2.2 => 5.2.2
    @storybook/addon-links: ^5.2.2 => 5.2.2
    @storybook/addons: ^5.2.2 => 5.2.2
    @storybook/react: ^5.2.2 => 5.2.2
    @storybook/storybook-deployer: ^2.8.1 => 2.8.1
    @storybook/theming: ^5.2.2 => 5.2.2
bug core
Source
picture pedroapfilho
👍2

Most helpful comment

Fixed! https://github.com/storybookjs/storybook/releases/tag/v5.2.3

Thanks for the quick notice on this. 🙇

picture shilman on 7 Oct 2019
🚀3

All 5 comments

@pedroapfilho Confirmed. It's a bad merge from next. Trying to fix it now!

shilman picture shilman on 7 Oct 2019
👍1

@shilman np! Thanks for that!

pedroapfilho picture pedroapfilho on 7 Oct 2019

Fixed! https://github.com/storybookjs/storybook/releases/tag/v5.2.3

Thanks for the quick notice on this. 🙇

shilman picture shilman on 7 Oct 2019
🚀3

@shilman thanks! Can confirm it's working now

selrond picture selrond on 7 Oct 2019
❤1

It's working! Thanks!

pedroapfilho picture pedroapfilho on 7 Oct 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

oriSomething picture oriSomething  ·  3Comments
arunoda picture arunoda  ·  3Comments
tirli picture tirli  ·  3Comments
rpersaud picture rpersaud  ·  3Comments
dnlsandiego picture dnlsandiego  ·  3Comments