Storybook: `babel-preset-react-app` listed as a dependency

Created on 25 Sep 2019  路  7Comments  路  Source: storybookjs/storybook

Describe the bug
The babel-preset-react-app package states that You don鈥檛 need to install it separately in Create React App projects. but it's listed as a dependency

To Reproduce
Look at package.json for @storybook/react

Expected behavior
It's not listed as a dependency because it's requiring specific versions that end up causing multiple versions of packages to be installed

System:

Environment Info:

  System:
    OS: macOS Mojave 10.14.6
    CPU: (8) x64 Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
  Browsers:
    Chrome: 77.0.3865.90
    Firefox: 69.0
    Safari: 12.1.2
babel / webpack cra dependencies

Most helpful comment

I think we need to remove this as a part of the migration to the preset. I've added it to the new task.

All 7 comments

@mrmckeb is this something you know about?

I think we need to remove this as a part of the migration to the preset. I've added it to the new task.

So what does that mean as far as timeline goes? Can we expect this to be fixed in the 5.3 release?

@daveisfera, I hope so - but it might take a little longer as this may be a breaking change for @storybook/react.

Great! Thanks for the update and hopefully it's doable. 馃

@shilman and I will need to discuss... basically, removing this from the package is fine - but then it would need to be installed by users alongside their package (when not using react-scripts).

Perhaps we'll need to move to peer deps and have a script that verifies existence.

Related commit that removed babel-preset-react-app runtime dependency from @storybook/react package

https://github.com/storybookjs/storybook/commit/942238acc8f2a87e83898d93c789818d391a2f06#diff-b5412b044e81f54a9cadb0982c0aa7c6

Was this page helpful?
0 / 5 - 0 ratings