Storybook: [addon-centered] Peer dependencies

Created on 4 Sep 2019  路  6Comments  路  Source: storybookjs/storybook

Describe the bug
The @storybook/addon-centered package has the following peerDependencies:

{
  "peerDependencies": {
    "mithril": "*",
    "preact": "*",
    "react": "*"
  }
}

Meaning installing it will always add 2-3 annoying warnings to a project. You'll never have more than 1 of those installed at the same time, and you can even use the addon without any of them.

Expected behavior
A package should not have peerDependencies that can't/won't ever be met. Please find a better solution (optionalDependencies?), or just remove the peerDependencies all together in this case.

centered bug inactive

Most helpful comment

Hey @leoyli here you go go go!! 馃殌

All 6 comments

optionalDependencies has the same problem. We should just remove the dependencies like in #7675

Hey @leoyli here you go go go!! 馃殌

Inactive? Fixed by #8156, maybe?

@Svish, yes fixed, stay tune 馃憖

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Fixed & released on both next and latest

Was this page helpful?
0 / 5 - 0 ratings

Related issues

xogeny picture xogeny  路  3Comments

ZigGreen picture ZigGreen  路  3Comments

miljan-aleksic picture miljan-aleksic  路  3Comments

arunoda picture arunoda  路  3Comments

tirli picture tirli  路  3Comments