Storybook: Theming and addon-notes code block

Created on 30 Jul 2019  路  7Comments  路  Source: storybookjs/storybook

Greetings!

Describe the bug
I use a custom theme for Storybook. barBg property changes background of blocks with code.

To Reproduce
Steps to reproduce the behavior:

  1. Create a .md file with code example inside.
  2. Import it in any story.
  3. Go to "Notes" section.
  4. See error.

Expected behavior
So, I expect barBg to change background of top bar only.

Screenshots
小薪懈屑芯泻 褝泻褉邪薪邪 2019-07-30 胁 11 27 12

Code snippets

// file with custom theme settings
import { create } from '@storybook/theming';

export const theme = create({
  base: 'light', // base theme

  appBg: '#f4f5f9',
  barBg: '#3f4557',
  barTextColor: '#ffffff',
  barSelectedColor: '#ebb242',
});

System:

  System:
    OS: macOS 10.14.5
  Binaries:
    Node: 10.16.0 - /usr/local/bin/node
    Yarn: 1.5.1 - /usr/local/bin/yarn
    npm: 6.9.0 - /usr/local/bin/npm
notes question / support theming

All 7 comments

By the way, version I use are

"@storybook/addon-notes": "^5.1.9",
"@storybook/addons": "^5.1.9",
"@storybook/theming": "^5.1.9",
"@storybook/vue": "^5.1.9",

Fixing this now.

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.10 containing PR #7623 that references this issue. Upgrade today to try it out!

w00t!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.19 containing PR #7623 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

I'm sorry, but I still have an issue with the theming (https://github.com/storybookjs/storybook/issues/7434):

Running on Storybook 5.2.0-rc.4 (angular).

My theme:

base: 'dark'

How the notes tab looks:

image

FYI addon-notes聽is being superceded by聽addon-docs. It鈥檚 reached release candidate (RC) status and will be properly released soon. Please give it a try!聽https://medium.com/storybookjs/storybook-docspage-e185bc3622bf

Was this page helpful?
0 / 5 - 0 ratings