Storybook: [addon-centered] installs not needed packages

Created on 13 Jun 2019  Â·  3Comments  Â·  Source: storybookjs/storybook

Describe the bug
@storybook/addon-centered installs preact and mithril packages in my react project. Why?

To Reproduce
Install @storybook/addon-centered and preact nad mithril will be installed as a required dependency...

Expected behavior
Do not install any not needed packages. See my package-lock.json

    "@storybook/addon-centered": {
      "version": "5.1.4",
      "resolved": "https://registry.npmjs.org/@storybook/addon-centered/-/addon-centered-5.1.4.tgz",
      "integrity": "sha512-WhMjlZFtQk1U9Te3eClUV10lp/ICcXh4FZ0pc2WEpDvoCvsSsXDV8Gr4b3x3Fiu4ytpHdRgqsxoPf8taNwXShg==",
      "dev": true,
      "requires": {
        "core-js": "^3.0.1",
        "global": "^4.3.2",
        "mithril": "*",
        "preact": "*",
        "react": "*",
        "util-deprecate": "^1.0.2"
      },
      "dependencies": {
        "core-js": {
          "version": "3.1.3",
          "resolved": "https://registry.npmjs.org/core-js/-/core-js-3.1.3.tgz",
          "integrity": "sha512-PWZ+ZfuaKf178BIAg+CRsljwjIMRV8MY00CbZczkR6Zk5LfkSkjGoaab3+bqRQWVITNZxQB7TFYz+CFcyuamvA==",
          "dev": true
        }
      }
    },

I have obviously react already installed. preact and mithril has been added to my node_modules

System:

  • npm - 6.9.0
  • framework: react

    • Version: 5.1.4

centered bug performance issue

Most helpful comment

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.37 containing PR #7315 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

All 3 comments

Probably still a problem mr bot

czw., 4 lip 2019, 22:44 użytkownik stale[bot] notifications@github.com
napisał:

Hi everyone! Seems like there hasn't been much going on in this issue
lately. If there are still questions, comments, or bugs, please feel free
to continue the discussion. Unfortunately, we don't have time to get to
every issue. We are always open to contributions so please send us a pull
request if you would like to help. Inactive issues will be closed after 30
days. Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/storybookjs/storybook/issues/7087?email_source=notifications&email_token=ACX2GNKLXQPWZ4VXX5N6AFTP5ZOLHA5CNFSM4HX2AH42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZIDORA#issuecomment-508573508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACX2GNMOD26FYBO66FET5Q3P5ZOLHANCNFSM4HX2AH4Q
.

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-alpha.37 containing PR #7315 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.10 containing PR #7315 that references this issue. Upgrade today to try it out!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

wahengchang picture wahengchang  Â·  3Comments

tirli picture tirli  Â·  3Comments

xogeny picture xogeny  Â·  3Comments

shilman picture shilman  Â·  3Comments

shilman picture shilman  Â·  3Comments