Storybook: React-Native Storybook v5.1.0rc3 add-on tabs cannot be seen on simulator.

Created on 31 May 2019  路  11Comments  路  Source: storybookjs/storybook

Describe the bug
After upgrading storybook-react-native to ver 5.1.3-rc, there is a lack of padding / margin around the app. Now I am not able to click on the add-on notes & knobs tabs.

Expected behavior
I should be able to click on the add-on tabs.

Screenshots
on ver 5.1.3-rc
image

on ver 4.1.18
image

System:

  • Device: iPhoneX simulator
  • Framework: React-Native
  • Addons: addon-ondevice notes & knobs
react-native bug ui

Most helpful comment

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.39 containing PR #7809 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

All 11 comments

Automention: Hey @benoitdion @gongreg, you've been tagged! Can you give a hand here?

tested on "@storybook/react-native": "^5.1.3", same issue

5.1.9, same issue here~ 馃槅
a temporary solution:
use iPhone 8 Plus or other 鈥渘one notch" device Instead of iPhoneX simulator~ lol

Hey. It seems that safe area view is missing as a wrapper for storybook. Would someone like to add it?

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Was this working on 4? If yes, I could do a bisect, but I don't know how big the changes were from 4 to 5.

Hey, I don鈥檛 think so. We need to addSafeAreaView wrapper. Could you add it?

I can do this if you haven't started already @pvinis

feel free to take this :)

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Crikey!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.39 containing PR #7809 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

Was this page helpful?
0 / 5 - 0 ratings