Storybook: "< />" symbols in storiesOf name cause "Maximum call stack error"

Created on 16 Mar 2019  路  7Comments  路  Source: storybookjs/storybook

Describe the bug
"< />" symbols in storiesOf name cause "Maximum call stack error"

Screenshots
image

Code snippets

storiesOf('Vue <docs/>', module)
  .add('Button', () => {
    return {
      components: {
        MyButton,
      },
      template: `<my-button>My Button</my-button>`,
    };
  });

System:

  • OS: macOS
  • Device: [e.g. iPhoneX, Macbook Pro 2018]
  • Browser: Chrome latest
  • Framework: vue
bug core good first issue has workaround high priority

Most helpful comment

I investigated this problem: look like trouble in your config:
if you add hierarchySeparator: /\./, in 'addParameters' arg problem is solved.
Of course, it's not very elegant solution, but it's working solution. 馃槃

All 7 comments

Thanks @tuchk4 -- good one! Can confirm this is an issue in core, reproducible in our examples for every view layer,.

Hi @tuchk4
Interesting issue. I can reproduce on vue and svelte. On react app all is ok.
I'll do it. 馃

I investigated this problem: look like trouble in your config:
if you add hierarchySeparator: /\./, in 'addParameters' arg problem is solved.
Of course, it's not very elegant solution, but it's working solution. 馃槃

Just got a dupe to this. @Armanio what's a better long-term solution?

Sorry, guys. Honestly, I forgot about this issue. Today I'll try find better solution.

Hi, guys! I'm back with a possible fix. Invite you in PR for discussion.

Gadzooks!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.35 containing PR #6607 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

purplecones picture purplecones  路  3Comments

sakulstra picture sakulstra  路  3Comments

xogeny picture xogeny  路  3Comments

wahengchang picture wahengchang  路  3Comments

arunoda picture arunoda  路  3Comments