Storybook: [addon: a11y] - rule open in one tab displays as open in another tab when navigating

Created on 15 Mar 2019  路  4Comments  路  Source: storybookjs/storybook

Describe the bug
When a rule is set to an open state, where you can see the details about the rule, it remains open in other tabs (pass, violation, incomplete)

To Reproduce
Steps to reproduce the behavior:

  1. Set up project
  2. Create a component with passing and failing and/or inconsistent rules

    • one rule must be common among at least 2 of the 3 tabs

  3. Open the common rule
  4. Switch between tabs and notice that the rule remains open

Expected behavior
All rules should close when switching between tabs

Screenshots
a11y-open-state-issue

System:

  • Browser: [chrome, firefox]
  • Framework: [Angular]
  • Version: [5.1.0-alpha.6]

Additional context
Found when developing feature #6001

a11y bug
Source
picture CodeByAlex

Most helpful comment

@shilman it actually? i can take this issue?

picture Armanio on 15 Mar 2019
👍2

All 4 comments

@shilman it actually? i can take this issue?

Armanio picture Armanio on 15 Mar 2019
👍2

That would be great @armanio!

CodeByAlex picture CodeByAlex on 15 Mar 2019

Done!

Armanio picture Armanio on 15 Mar 2019

Crikey!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.7 containing PR #6118 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

shilman picture shilman on 16 Mar 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ZigGreen picture ZigGreen  路  3Comments
sakulstra picture sakulstra  路  3Comments
oriSomething picture oriSomething  路  3Comments
tirli picture tirli  路  3Comments
rpersaud picture rpersaud  路  3Comments