Storybook: [5.0.0] Prop type error in the console when resizing browser window to less than 600px

[web-padawan]

Describe the bug
The following error appears in the console:

Warning: Failed prop type: Invalid prop `active` of type `boolean` supplied to `<<anonymous>>`, expected `number`.
    in Unknown (created by MobileLayout)
    in MobileLayout (created by ResizeDetector)
    in ResizeDetector
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root

To Reproduce
Steps to reproduce the behavior:

1. Resize the window to be less than 600px
2. See the console
3. When refreshing page in a small window, error appears again

Expected behavior
No error in the console

Screenshots

System:

• OS: MacOS
• Device: Macbook Pro 2017
• Browser: Chrome, Firefox, Safari are affected
• Version: 5.0.0 (edit: happens also with 5.0.0-rc.7)

[shilman]

Huzzah!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.35 containing PR #6241 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

[chriscarpenter12]

I'm still seeing this same error with v5.1.8

Warning: Failed prop type: The prop `active` is marked as required in `<<anonymous>>`, but its value is `undefined`.
    in Unknown (created by MobileLayout)
    in MobileLayout (created by ResizeDetector)
    in ChildWrapper (created by ResizeDetector)
    in ResizeDetector
    in div (created by Context.Consumer)
    in Styled(div)
    in Unknown
    in Unknown (created by Manager)
    in ThemeProvider (created by Manager)
    in Manager (created by Context.Consumer)
    in Location (created by QueryLocation)
    in QueryLocation (created by Root)
    in LocationProvider (created by Root)
    in HelmetProvider (created by Root)
    in Root

[web-padawan]

Can this bot be instructed to not treat the issue labelled as "bug" as inactive? 🤔

[shilman]

@web-padawan yes if you add the label "in progress". but AFAIK is not in progress.

[EdwardStepanian]

Hi all. I and my company front staff also faced this issue. It's not appropriate for our stakeholders to have this warning. We work hard on code quality and pay attention to any warning in console, which is important for us and our clients. If you are not going to resolve the following issue, please let us know so we can look for another platform. But we would like to see the issue resolved in yours.

[denisbabineau]

+1 if it would be more critical to me I'd investigate further but it's mostly a small nuisance at this point

[datajohnny]

+1 this issue

[selbyk]

+1

[shilman]

Is this still an issue in 5.2?

[immortal-tofu]

It still appears in 5.2 for me

[leepowelldev]

Can confirm I'm seeing this in 5.2 also

[hon9g]

this bug is still in

"@storybook/addon-actions": "^5.2.1",
"@storybook/addon-links": "^5.2.1",
"@storybook/addons": "^5.2.1",
"@storybook/react": "^5.2.1"

[stanf0rd]

+1 on [email protected]

[seanforyou23]

+1 this is still an issue in [email protected]

[tenjojeremy]

Still an issue in 5.2.3

[KamaKAzii]

+1

[amalv]

@EdwardStepanian You could use the Storybook Viewport Addon, this way you can still see mobile view and the console won't show the error message.

[shilman]

@ndelangen Did this regress? https://github.com/storybookjs/storybook/issues/8819

[ndelangen]

What makes you think it did @shilman ?

[shilman]

@ndelangen That somebody filed #8819 yesterday saying it did

[ndelangen]

Was the PR not picked?

The new bug report has:
"@storybook/react": "5.2.6"

This PR: https://github.com/storybookjs/storybook/pull/8583 has the patch label, but not picked on it?

[ndelangen]

I'll fix this on master too

[shilman]

Good golly!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.7 containing PR #8941 that references this issue. Upgrade today to try it out!

Closing this issue. Please re-open if you think there's still more to do.