Storybook: Webpack performance options are ignored

[sucat]

Describe the bug
I have a separate webpack config for storybook. I can see some Webpack Performance hints which I want to disable. It looks like webpack performance options are ignored.

To Reproduce
Steps to reproduce the behavior:

1. Go to webpack.config.js within storybook directory
2. Add performance: { hints: false }, under module.exports
3. Build storybook

Expected behavior
There are no performance warnings in build task output.

Actual result
Performance warnings are present

info @storybook/react v4.1.13
info
info clean outputDir..
info => Copying prebuild dll's..
info => Building manager..
info => Loading manager config..
info => Loading presets
info => Loading custom addons config.
info => Compiling manager..
info => manager built (7.07 s)
WARN asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
WARN This can impact web performance.
WARN Assets:
WARN   vendors~main.a69a2620226abd109378.bundle.js (1.03 MiB)
WARN entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
WARN Entrypoints:
WARN   main (1.03 MiB)
WARN       runtime~main.bf7f1bbd18bd2f1ec8df.bundle.js
WARN       vendors~main.a69a2620226abd109378.bundle.js
WARN       main.9f9e1f2191ed6df38227.bundle.js
WARN
WARN webpack performance recommendations:
WARN You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
WARN For more info visit https://webpack.js.org/guides/code-splitting/
info => Building preview..
info => Loading preview config..
info => Loading presets
info => Using base config because react-scripts is not installed.
info => Loading custom webpack config (extending mode).
info => Compiling preview..
info => Preview built (6.1 s)
WARN asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
WARN This can impact web performance.
WARN Assets:
WARN   vendors~main.ea6427ff01a185e4ca93.bundle.js (848 KiB)
WARN entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
WARN Entrypoints:
WARN   main (1.1 MiB)
WARN       runtime~main.ea6427ff01a185e4ca93.bundle.js
WARN       vendors~main.ea6427ff01a185e4ca93.bundle.js
WARN       main.01b5b045a8bc2caa39a4.css
WARN       main.ea6427ff01a185e4ca93.bundle.js
WARN
WARN webpack performance recommendations:
WARN You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
WARN For more info visit https://webpack.js.org/guides/code-splitting/

System:

• Webpack version: 4.29.3
• Storybook version: 4.1.13

[claudio-moya]

same issue here, by using webpack 4 the "full-control-mode" doesn't fully work and I still get the fat main bundle over 1MiB.

From my case, some changes works for the 'iframe.html' JS files but the JS files for index.html don't change at all -> the fat main bundle.js

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[shilman]

Has anybody tried this with SB5?

[sucat]

@shilman
Yes, I did. The issue still persist on:
Webpack: 4.29.6
Storybook: 5.0.5

[shilman]

Boo-yah!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.27 containing PR #6390 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

[absalonv]

I am using 5.13.13 and still see the warning.