Storybook: Addon-a11y: Show "incompletes" in a tab
Currently addon-a11y displays passes and fails. However, the underly library we use also returns "incompletes" that could not determined to be passed or failed. We should show these in a tab!
Hat tip to @gaetanmaisse for the feature suggestion: https://github.com/storybooks/storybook/issues/5774#issuecomment-467608025
shilman
All 7 comments
Hmm, intresting.
Can i do it?
Armanio
on 5 Mar 2019
Sure @Armanio! But I think we should wait to merge https://github.com/storybooks/storybook/pull/5738. I will resolve conflicts this week and check with @shilman when we can merge it.
gaetanmaisse
on 5 Mar 2019
Got it!
Armanio
on 5 Mar 2019
@gaetanmaisse we can merge whenever conflicts are resolved 馃憤 thanks for checking!
shilman
on 6 Mar 2019
@Armanio https://github.com/storybooks/storybook/pull/5738 is merged so you can have fun with addon-a11y now!
gaetanmaisse
on 8 Mar 2019
Ready! Check it!
Armanio
on 9 Mar 2019
Yowza!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.3 containing PR #5984 that references this issue. Upgrade today to try it out!
Because it's a pre-release you can find it on the @next NPM tag.
Closing this issue. Please re-open if you think there's still more to do.
shilman
on 9 Mar 2019
Related issues
shilman
路
3Comments
purplecones
路
3Comments
sakulstra
路
3Comments
Jonovono
路
3Comments
alexanbj
路
3Comments
Most helpful comment
Ready! Check it!