Storybook: Toolbar should not have separators between each addon icon

Created on 15 Feb 2019  路  4Comments  路  Source: storybookjs/storybook

Describe the bug
Icons in the toolbar should not have separators between each of them. Separators should only appear if there are more than two icons present in a feature or addon (i.e., like the Zoom feature).

To Reproduce
Steps to reproduce the behavior:

  1. Go to Storybook that has Toolbar addons
  2. See that each icon that corresponds to addons has a toolbar between it

Expected behavior
There shouldn't be separators here:
image
or here
image

bug ui

All 4 comments

But I think they are nice to have, at least it is clear to me what kind of add-on are grouped...?!

Each icon already represents discrete functionality - they don't need to be further separated from other icons to achieve that.

So they end up occupying more horizontal space yet don't communicating anything new.

This is fixed?

Yowza!! I just released https://github.com/storybooks/storybook/releases/tag/v5.0.0-rc.5 containing PR #5711 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

shilman picture shilman  路  3Comments

Jonovono picture Jonovono  路  3Comments

arunoda picture arunoda  路  3Comments

zvictor picture zvictor  路  3Comments

rpersaud picture rpersaud  路  3Comments