Storybook: Addons panel position resets with each knob change

[emyarod]

Describe the bug
The position of the addons panel position resets with each story or knob change

To Reproduce
Steps to reproduce the behavior:

1. Reposition addons panel (cmd+shift+G or ctrl+shift+G)
2. Click on a different story or modify a story knob

The panel will then reset its position

Expected behavior
The storybook should remember the position of the panel for the current session

Screenshots
If applicable, add screenshots to help explain your problem.

System:

• OS: MacOS 10.14
• Device: Macbook Pro 2018
• Browser: Chrome 70+, Firefox 65+
• Framework: react
• Addons: a11y, actions, info, knobs, links, options, storysource
• Version: 4.0.4

[igor-dv]

IMO shortcuts are not persistent.
@ndelangen, @Jessica-Koch, will this be handled in the ui overhaul?

[Jessica-Koch]

Yes this was held up because of a bug that caused the constructor to load twice

Sent from my iPhone

On Dec 5, 2018, at 9:48 AM, Igor [e-mail] wrote:

IMO shortcuts are not persistent.
@ndelangen, @Jessica-Koch, will this be handled in the ui overhaul?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[igor-dv]

Can the fix be extracted to v4?

[Jessica-Koch]

I think Norbert fixed the bug, I was blocked working on the keyboard shortcuts, I actually was going to work on finalizing the persistence and changing the ui of the shortcuts menu.

Sent from my iPhone

On Dec 5, 2018, at 11:21 AM, Igor [e-mail] wrote:

Can the fix be extracted to v4?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[Jessica-Koch]

Sorry if that doesn’t answer the question, I have no idea when things are getting released. I took off work to work on this today

Sent from my iPhone

On Dec 5, 2018, at 11:21 AM, Igor [e-mail] wrote:

Can the fix be extracted to v4?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[mrlubos]

I experience this issue when I load up Search box (⇧ + ⌘ + O) and then press Esc to close it. If I perform a search and select a result, this bug is not present.

[stale[bot]]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[nicgirault]

This issue is still happening and very frustrating to work on components

[shilman]

@nicgerault v5?

[malykhinvi]

Click on a different story

This part of the bug is the same as https://github.com/storybooks/storybook/issues/6114, though 6114 is not related to knobs. @shilman should we consider these two tickets as duplicates, or these are separate ones?

[shilman]

Sure, let's pick this up in #6114. Closing this as a dupe.