Storybook: @storybook/angular shouldn't depend on zone.js

[emilio-martinez]

Describe the bug
Currently, @storybook/angular lists zone.js within its dependencies; however, (as far as I can tell) in practice @storybook/angular doesn't actually depend on it. Of course, Angular does but perhaps it's worth removing it as a @storybook/angular dependency to avoid conflicts.

To Reproduce
See https://github.com/storybooks/storybook/blob/v4.0.0/app/angular/package.json#L44.

Expected behavior
@storybook/angular shouldn't depend on zone.js if it doesn't use it.

Screenshots
N/A

Code snippets
N/A

System:

• OS: MacOS
• Device: Macbook Pro 2017
• Browser: Chrome
• Framework: Angular
• Addons: none
• Version: 4.0.0

Additional context
N/A

[kroeder]

@igor-dv @storybook/angular does not depend on it. Wasn't it core or something? We already had a discussion about zone.js

[emilio-martinez]

Sorry, re-read my description and realized it was very odd/poorly written 😅updated.

[igor-dv]

It's used in polyfills

https://github.com/storybooks/storybook/blob/master/app/angular/src/client/preview/angular-polyfills.js#L53

Do we really need these polyfills, though ?

[kroeder]

Well, this time zone.js isn't a dependency of a dependency (like webpack is just a dep of angular core). zone.js is a direct dep of n angular app - maybe we can put zone.js as peer dep and dev dep for development this time?

[igor-dv]

Yep. It should work

[emilio-martinez]

Peer dependency makes sense. The way I see it, Storybook should be pulling the version of zone.js already being used in the host Angular project anyway, unless there's a specific task Storybook is using zone.js for that differs from the rest of the project.

[igor-dv]

Wanna PR this ?

[emilio-martinez]

For sure. Opened!