Storybook: iframe.html is not aligned in webpack.config.js' `publicPath`

Created on 2 Jun 2018  路  8Comments  路  Source: storybookjs/storybook

I can confirm, believing to experience the same issue

"manager.bundle.js" and "preview.bundle.js" is requested relative to my publicPath but not for "iframe.html".

Details

I'm trying to host storybook's output on a path (http://something.com/storybook) and "iframe.html" is being requested at http://something.com/ where /storybook is my publicPath in my webpack.config.js

Steps to reproduce

Build the project and see manager.bundle.js. Search for "iframe.html" and see that publicPath is not included.

Upon quick investigation, I think this seems to be the problem. But I wonder If that line can check the webpack's publicPath to append to.

Please specify which version of Storybook and optionally any affected addons that you're running

  • @storybook/react 3.4.2

Affected platforms

N/A

Screenshots / Screencast / Code Snippets (Optional)

N/A

babel / webpack feature request inactive

All 8 comments

I wonder if simply changing that url to ./iframe.html?... would fix the problem.

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Is it still a problem after the discussion in #3172

As @danielduan mentioned, I think it would be better if the request to iframe.html would align to webpack's publicPath via changing it to ./iframe.html.

_So even though I was able to find a temporary workaround_, yes, its still a problem for me.

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

+1 I am using storybook in a bit of a weird way where we upload all files to a CDN and serve from a server that wants to point to CDN for all static files. So we make great use of publicPath. However, for iframe.html we've had to be a bit creative (essentially create a redirect rule on the server). It would be lovely if we could avoid that.

Can confirm this show-stopping bug.

Was this page helpful?
0 / 5 - 0 ratings