Storybook: Allow fileExt to be optional

Created on 25 Nov 2017  路  11Comments  路  Source: storybookjs/storybook

Most helpful comment

@ndelangen just dabbling into open source. Would make a PR.

All 11 comments

Looks like it's just a matter of using empty string as a default value. If anybody wants to make a PR, go for it

If anyone new to storybook or open source in general wants to take this issue, I'm available to help!

@ndelangen just dabbling into open source. Would make a PR.

@Promhize
You'll have to

  1. Fork the repo
  2. Clone the forked repository to your computer
  3. Create a branch named feature/default-
  4. Edit the following file: addons/jest/src/index.js
    The change to apply: change line 3 from:
    js const findTestResults = (testFiles, jestTestResults, jestTestFilesExt) =>
    to:
    js const findTestResults = (testFiles, jestTestResults, jestTestFilesExt = '') =>
  5. Commit the changed file and push to the remote
  6. Go to our github page here: https://github.com/storybooks/storybook
  7. GitHub should suggest to open a PR, if it doesn't you should be able to select your branch and our master branch here to create one: https://github.com/storybooks/storybook/compare (our master branch should be the base.
  8. Describe the change you made in the title and description.
  9. Wait for someone to review the PR.
  10. It should be merged pretty quick!

@ndelangen thanks. Looking to make further contributions. You all are awesome

Done, but not released yet

Yes, please. Sorry for the lack of documentation regarding it.

@Promhize drop by our slack channel.

That way we can collaborate much easier and faster, if you want to do more collaboration I can help get you on-boarded on the project.

Was this page helpful?
0 / 5 - 0 ratings