We're opening this issue to inform you about problems with your dependencies.io configuration or build failures.
We'll add a comment here when we see problems. You can close this issue when
you have things resolved -- we'll open it back up if we detect new problems.
Helpful links:
Note: To help keep your repo as clean as possible, this is the only issue
that we're going to open and comment on. Feel free to delete the comments
that are made as you resolve them, if you want to keep this issue short and tidy.
@davegaeddert is there a chance that lerna collector is bound to a specific lerna version?
https://app.dependencies.io/projects/github/storybooks/storybook
lerna info version 2.2.0
lerna ERR! EMISMATCH Lerna major version mismatch: The current version of lerna is 2.2.0, but the Lerna version in `lerna.json` is 2.3.1. You can either run `lerna init` again or install `[email protected]`.
I believe it should use local lerna version with yarn lerna <command>
instead of global one
@Hypnosphi good point. We pushed an update to both the collector and actor (decided to add the repo's node_modules/.bin
to the path instead). I tested it on a fork and it ran fine, but let me know if you have any more trouble. Thanks!
Build # 11 on master (f355399e0de4b9cb1c91ba1969bc37f6c8fe6235) failed!
Build # 15 on master (81152d5c766d02d790d99c49d5e94dafb9a84d1f) failed!
@davegaeddert the same problem, this time in actor: https://app.dependencies.io/projects/github/storybooks/storybook/builds/15
Build # 16 on master (3036b2c58bcc0b98f09860011a45425bedb7ed22) failed!
@Hypnosphi I'll take a look.
Build # 17 on master (3036b2c58bcc0b98f09860011a45425bedb7ed22) failed!
Build # 18 on master (173083412abac06f833e9dc995a94608081bc2db) failed!
@Hypnosphi I think the actor should be working now. The collector failed because it looks like somewhere in the last couple commits some babel/vue dependencies were introduced but not added to yarn.lock
? Our collector quits if it notices uncommited yarn.lock
changes so that you don't get a bunch of pull requests that all include those (unrelated) changes with them.
The issue with the actor might need a little more thought, but should work for how you're using it right now since your bootstrap command is just yarn
. The problem is that you have to install the local lerna before you can use it...otherwise you get that version mismatch between what the local repo asks for and what our current global version is. Is that why your bootstrap command no longer uses lerna bootstrap
? Did I see that you (or someone on storybook) is also involved in lerna development? I was reading some issues about global vs local questions -- what is the general way that you use lerna in development? Do you have a version of lerna installed globally on your machine? Or local? Or both?
Sorry for all the questions -- if anybody has an expertise on this, comments are welcome! We just want to make sure that anything we build around lerna works the way that people expect. From what I can tell, these questions on the collector/actor are probably similar to what you've had to deal with in development.
some babel/vue dependencies were introduced but not added to yarn.lock
Will fix that.
@ndelangen btw such cases can be prevented with #1980
Is that why your bootstrap command no longer uses
lerna bootstrap
The reason is that we find it convenient to use a single command to install both root and package s dependencies
what is the general way that you use lerna in development
I just always use yarn lerna <command>
Build # 27 on master (c2f605c77283646ffc097d4bcd01521b068bd114) failed!
@davegaeddert I failed to find out what's the error here: https://app.dependencies.io/projects/github/storybooks/storybook/builds/27
@Hypnosphi looks like it just timed out (20 min. limit). Still need to get that error messaging to reflect that so it's more obvious.
Hello! Not sure if of any help, but I'm having similar issues with dependencies.io (not withlerna actor that I still need to try).
I found that omitting the settings kinda solved a similar error.
Build # 51 on master (725ac4b73ba728a2b7444a29e5b1e20a64a65500) failed!
Build # 57 on master (f48fbd323157fadaf5b23912716a44460e5fb3e9) failed!
@davegaeddert is it React release that breaks the build? https://app.dependencies.io/projects/github/storybooks/storybook/builds/57
Btw, what does this "actions" column mean, exactly?
Build # 58 on master (16cb94d7b2bd66d9c34a745146ef96decc959e52) failed!
Build # 59 on master (50dc2f1c137e3cd9e86a2782719facff8ea5a33b) failed!
@Hypnosphi I'll take a look. The actions column is just saying how many actors ran (on that build) for that particular dependency. Admittedly, the UI needs some updating now that we have a better feel for how things work and how people use it.
Build # 60 on master (6897edb10024853fa1e837396a9a7470c75062da) failed!
@Hypnosphi so apparently there are so many updates (and release notes) with all those React updates that it is too big to pass into the container in the way we're doing it currently. We just saw this yesterday for the first time and I'm surprised it hasn't come up before -- especially on your repo which AFAIK has more dependencies than anyone else. I would say that if you do the react
and react-dom
updates by hand, then it should clear up the bulk of it and get things running again. I'll open an issue and we'll talk about some steps to address it across the board.
Yeah, that was my guess, that's why I opened #2285
Actually, almost all of those are devDependencies
so we'll consider replacing them with devDependencies
in root
Build # 65 on master (7a1f7c4d0220f1d03c710040798eabaf9d4e5b2f) failed!
Build # 69 on master (e7cf06787a45b4fdd5195a9163b6149e02dc55f3) failed!
Build # 70 on master (18ae5324c964a50419b00d154944dba6f94f5059) failed!
@davegaeddert
https://app.dependencies.io/projects/github/storybooks/storybook/builds/70
ERROR: Failed to download Chromium r515411! Set "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" env variable to skip download.
can I set this in actor config?
@Hypnosphi it looks like you can also disable it using an npm config setting. I think there should be a few ways to set a config option like that, our npmrc
setting may be the best to cover every possibility. Haven't tried this but what if you do:
settings:
npmrc: |
puppeteer_skip_chromium_download=true
Build # 78 on master (d9308d62d9b9cc57ce683e9e13433f7d7ae8a6e8) failed!
Build # 84 on master (a6a5f9fe81fed720aeecbac15d4adcee8780101c) failed!
Build # 85 on master (a6a5f9fe81fed720aeecbac15d4adcee8780101c) failed!
Build # 86 on master (ab7660d0ec0e6c8df0167e6bbc929a1d5abdbedc) failed!
Build # 87 on master (fea626a434bdb1a9ebbec87cddea1bbcc4147f11) failed!
Build # 88 on master (34608bf1ef8930644c604f6340bc62a190f0a3ed) failed!
@Hypnosphi too many updates for a batch PR again?
Looks like it. In fact, it does an unneeded job when running npm install package-name@version --save
in package dir, and then yarn install
in root. If the first step was yarn add package-name
, it would save time (and probably memory), because yarn is aware of workspaces, and the subsequent yarn install
would just yield "Already up to date"
Yeah, so I think the reason it worked that way originally had to do with the yarn + lerna + --hoist
combination...which I feel like I saw is no longer even supported now that yarn workspaces are a thing? What I'm wondering is if what we really need to do is just add support for workspaces to the normal js-npm collector/actor. I think we could get some of those improvements you're mentioning and it might allow us to refocus a little bit on what "yarn" support looks like, and separately what "lerna" support looks like.
Would that make sense to you? As we talked about, lerna doesn't really have anything to do with how you install dependencies now -- it's really just yarn workspaces.
Yeah, makes sense
BTW, when using monorepo (with lerna or yarn workspaces), you can't really do npm install something
in package directory safely. For example, if monorepo contains a package that wasn't ever published, and another package depends on it, npm install
will fail because of an unmet dependency. With lerna, there are actually no good way to add/updgrade dependencies in packages AFAIK. The only thing you can do is update package.json manually and then run bootstrap command.
On the other hand, with yarn workspaces you can do yarn upgrade package-name
in package directory, and it'll work OK, because yarn is aware of workspaces
Build # 89 on master (cc8b312c84de515a533872671a533fa15eb1b7e0) failed!
Build # 90 on master (cc8b312c84de515a533872671a533fa15eb1b7e0) failed!
Build # 91 on master (703bf996c29ccf83d896b781de7da3c596fa902e) failed!
Build # 93 on master (5e813170e2d1797667a7ca5dcbe1c4f95ed076c0) failed!
Build # 94 on master (0b256f55b92dd7b3b012303860b00841e36d6727) failed!
Build # 100 on master (7ba7de5b4eb55ba5932ffe6c58677629a30bb7fe) failed!
Build # 101 on master (7ba7de5b4eb55ba5932ffe6c58677629a30bb7fe) failed!
Build # 102 on master (7ba7de5b4eb55ba5932ffe6c58677629a30bb7fe) failed!
@davegaeddert looks like it's not so much updates this time (9):
https://app.dependencies.io/projects/github/storybooks/storybook
@Hypnosphi it still takes a long time though the way it works currently (runs install twice essentially each package). I opened an issue here: https://github.com/dependencies-io/actor-js-lerna/issues/25
I'll try do look into it a little further, but it seems like that is at least one major step we could take in improving this (although I still think separating yarn workspaces from lerna will be the right direction in the end). Any thoughts would be much appreciated!
Just adding install_command
option which would accept package@version
argument would be enough. We could just pass yarn add
there, and yarn would keep the type of dependency (dev/peer/optional)
Build # 116 on master (043f03ce03d1dbedae96bf3bbac0c1941806c0b3) failed!
Build # 117 on master (8b2064fa17b3d6a914f6fecd996c88c342ae20e3) failed!
Build # 118 on master (3cc66e39c59de767d26e70664b0d166c440d9c56) failed!
@davegaeddert looks like it runs for too long again =( https://app.dependencies.io/projects/github/storybooks/storybook/builds/118
Is there a way to run bootstrap_command
only after all the updates in the batch are made?
Build # 119 on master (bfafaa8bd0d32d357f1a893f579edfd56e7cdc67) failed!
@Hypnosphi shoot. Running bootstrap_command
at the end would definitely help...but then each individual commit wouldn't have the yarn.lock changes to go with the individual dependency update, right? What about trying --prefer-offline
with your bootstrap_command
? Would there be any major downside to that?
but then each individual commit wouldn't have the yarn.lock changes to go with the individual dependency update, right?
That's Ok. If I revert a particular commit, that means that I have already checked out the branch and it's not a big deal to update lockfiles after that.
Anyway, will try the prefer-offline
approach
Ok, let me know how it goes. I appreciate the feedback (and the patience).
Build # 129 on master (c275e5c508714bd1a49342e51ddf00bbdb54d277) failed!
Build # 131 on master (173b1d1f61f0fd16c5c42e198301d131435cd7e0) failed!
Build # 132 on master (4cbc69731db8e6c29277a7d15d8c5a5ff1f19d14) failed!
Build # 133 on master (795b01cd6233268fcabe62ea04a44a4e26403df6) failed!
@davegaeddert It's still failing on 9 updates
Build # 134 on master (05b072c508e5e2b756079fcd185b0214adc13ace) failed!
@Hypnosphi ok, I increased the time limit to 45 minutes for now. That's more than double what it was. We're in the middle of working through what is essentially turning into a "v2" of the whole system -- which factors in all of the feedback and things that we've seen so far. Hopefully, it will deal with most of these kinds of problems, while also introducing some new UI and workflows for managing dependencies (and lockfiles specifically).
Build # 138 on master (a9d7440fa59533d5b373e32bfd2e15be44557a64) failed!
Build # 139 on master (a9d7440fa59533d5b373e32bfd2e15be44557a64) failed!
Build # 165 on master (65a121fea27cf49f3877dd466304d41e794c0e54) failed!
Build # 166 on master (036002b84c4d9bf9776a6c032e6e7ff9c7e95d4c) failed!
Build # 175 on master (93e85821cc80e8ad7799be2b17fb9eca6ba00d6f) failed!
Build # 176 on master (8fadf670ab247dfe00c25e02d88b4464a403bc2b) failed!
@davegaeddert for some reason, daily builds don't start anymore: https://app.dependencies.io/projects/github/storybooks/storybook/builds
Thanks @Hypnosphi -- I found a bug and got it fixed. Should run tomorrow.
Now it just fails and doesn't even report it here =(
Build # 183 on master (bb46b676d92ce0ef1a38345cf04fc746dfe29aa4) failed!
Build # 184 on master (bb46b676d92ce0ef1a38345cf04fc746dfe29aa4) failed!
Build # 185 on master (cadcda79a1272e0e0ef225190d0d15bf21bebcd4) failed!
Build # 201 on master (d82d634e3068688def4319170c4c41219cae93fa) failed!
Build # 209 on master (e86bad1df456f647f07247e9bfd4ed9252373e46) failed!
Build # 210 on master (a78016c4c9ba9defdd4a5ef86cdf6bbc78e83425) failed!
Build # 211 on master (0e919925b97f3bfccb32812741ed2e638dbcbd09) failed!
collectors:
# Temporarily disabled
# - type: js-npm
# path: examples/crna-kitchen-sink
# actors:
# # pull requests for updates to our major version
# - type: js-npm
# versions: "L.Y.Y"
# # create issues for new major versions
# - type: repo-issue
# versions: "Y.0.0"
# Temporarily disabled
# - type: js-npm
# path: examples/react-native-vanilla
# actors:
# # pull requests for updates to our major version
# - type: js-npm
# versions: "L.Y.Y"
# # create issues for new major versions
# - type: repo-issue
# versions: "Y.0.0"
- type: js-lerna
path: /
settings:
collect_root: true
bootstrap_command: yarn --ignore-scripts --ignore-engines --silent --prefer-offline
actors:
# pull requests for updates to our major version
- type: js-lerna
dependencies_not_matching: "^react-native$"
versions: "L.Y.Y"
settings:
batch_mode: true
bootstrap_command: :
# bootstrap_command: :
# ^
# --------
# Basic YAML parsing error
# - mapping values are not allowed here
# --------
github_labels:
- dependencies:update
github_assignees:
- Hypnosphi
# create issues for new major versions
- type: repo-issue
versions: "Y.0.0"
settings:
github_labels:
- dependencies:update
github_assignees:
- Hypnosphi
- type: js-npm
path: docs
actors:
# pull requests for updates to our major version
- type: js-npm
versions: "L.Y.Y"
settings:
batch_mode: true
github_labels:
- dependencies:update
github_assignees:
- Hypnosphi
# create issues for new major versions
- type: repo-issue
versions: "Y.0.0"
settings:
github_labels:
- dependencies:update
github_assignees:
- Hypnosphi
Once you fix it, a new build will be started automatically.
Build # 218 on master (3e9d6be6418fd50fbbbe5ead2b09dbf34f3e0272) failed!
Build # 219 on master (3e9d6be6418fd50fbbbe5ead2b09dbf34f3e0272) failed!
Build # 223 on master (56c1bef3bc17d5f23a2be06ff37f745d5d1fa5d2) failed!
Build # 227 on master (90ea6d900b4da815f102be3c879d0f5c9dec1727) failed!
Build # 228 on master (14d598316d7b9003cef36ad2b24c0bf62881d4d6) failed!
Build # 236 on master (cd5dc85ea853d3ec878318d04a64cc8c35c0ca4d) failed!
Build # 237 on master (7bb9a843a8480a41d2424dcf0705af4e319e7042) failed!
Build # 238 on master (58715749d98a66319bc89a7aefc209f5351d175c) failed!
Build # 271 on master (43adb98d07c8cf8ed1970ed3a72c5ae0d5961817) failed!
Build # 278 on master (de93812ed18f4cd7aef24c0aa5552394d241ee6f) failed!
Build # 280 on master (4afed6660fa0fc1976df1c6de375231d2f68bf83) failed!
Build # 284 on master (c94bcddb56dd9eb2560bca043a33f9bbb7d6b94c) failed!
Build # 286 on master (0fe88b6b828dee79b0b4c4686ff0d216e19db301) failed!
Build # 289 on master (e459e209385067a06da42a18ba7f080125564a48) failed!
Build # 290 on master (e459e209385067a06da42a18ba7f080125564a48) failed!
Build # 291 on master (e459e209385067a06da42a18ba7f080125564a48) failed!
Build # 297 on master (ad363e023588fd7d9e293aa4eae49068493da554) failed!
Build # 300 on master (55d6d6d45a26c42800169181158e8ce9ce7da47c) failed!
Build # 306 on master (9340ddeaa906fc1e4cc0dcb1b437cd552327780c) failed!
Build # 309 on master (337412e177fc2fb8de4282d0f95f6e6673a3ee05) failed!
Build # 314 on master (a881e517bf2e5bb7d2cabc3e449c3a3999e2cad7) failed!
Build # 320 on master (9bbe5cc405bf5cce1c55c81147c13d75c95892b3) failed!
Build # 321 on master (965411ff5a5c6ee502413cbf5ccca0f7cfaef7b5) failed!
Build # 322 on master (2488fe95a12412f9cd037558934480d27eb5e27a) failed!
Build # 323 on master (2675c19144e6eb33d6460157b3133a3ce056d943) failed!
Build # 324 on master (eb4bc2ab5f570e0847ab94cccb34b23ac4a77d86) failed!
Build # 326 on master (393569781ab34b75ccde0bc17b0199537f1b57a4) failed!
Build # 328 on master (73427072feb3677e098229576c20880b6e46bad2) failed!
Build # 332 on master (03cb6c56b8237855f217a131bf389530eb55657a) failed!
Build # 337 on master (4b6d661102ae94bf0ed4f009be67cbdb2190ee5d) failed!
Build # 339 on master (c25731ff151cad6008028b90cd1bb580fc6f9bc0) failed!
Build # 342 on master (80046785e3be3b1b4fa07d52ef5de39276da12b5) failed!
Build # 344 on master (bcff86c7cf3419ae7598d353d170f69587072933) failed!
Build # 346 on master (407cc6735596daa42d1f64e95b17a92eec585dbc) failed!
Build # 348 on master (23b54f9db9352526b7842230ecc940c2d5e479dd) failed!
Build # 349 on master (b4d4704e7accee27ba9d9619fcb7d4ba441a1883) failed!
Build # 351 on master (4a250fb7da698175a46fbe47f0a0125b1ce0775b) failed!
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!
Build # 357 on master (5f279c1a99ea2f99e5038f4922400d399741a4d8) failed!
Build # 358 on master (f49c44482618ca77e8134b53aba58d6138b662ed) failed!
Build # 362 on master (b2b275b32bb35db8c5038c43ddc331875502be31) failed!
@Hypnosphi How do I find the problem? I do not know how to fix it..
@davegaeddert Hi! Looks like it tries to upgrade all the babel packages (and maybe others too, like eslint) from stable to beta: https://v1.dependencies.io/projects/github/Hypnosphi/storybook
Is there a chance that L.Y.Y
started mistakenly matching 7.0.0-tag
for 6.0.0
as current version?
Hi! @Hypnosphi did you mean to link to Hypnosphi/storybook instead of storybooks/storybook? Looks like they have different configs, just want to make sure we're on the same page first.
Build # 363 on master (4121d263f51fdbe1bcf4ba7be5abbdafdd2d8268) failed!
Build # 364 on master (b7054f3a0d75f096303df900a75bba505eb23520) failed!
@davegaeddert sorry, my bad. Looks like some bad node version is used then:
https://v1.dependencies.io/projects/github/storybooks/storybook
The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0"
@Hypnosphi ok thanks. I'll see if we can get that fixed, but we're no longer actively maintaining the v1 components. I know we talked about this a bit before, but do you know what would be holding you back from switching to v2 at this point? What's the biggest outstanding question there?
Build # 365 on master (9d2756c6c1cec1a8ad754d9fe63fc61adaccc7f6) failed!
Build # 366 on master (a2a2a914275296f5776b92cd36d45811a5b377d3) failed!
Build # 367 on master (bd9c701d75c74a1f8d25171b49af63932e9e986d) failed!
Build # 368 on master (c14b250f63b3d96766572429788b452d459f39f0) failed!
Build # 369 on master (dd1953c9539ad8a1d3d7799baa63d9610df88489) failed!
Build # 370 on master (621a4ed603ebd0875a64f9f58ed15d17758c8626) failed!
Build # 371 on master (f7ccb82146ad01e51ffc94a8cb261bb141cd0f7b) failed!
Build # 372 on master (f7ccb82146ad01e51ffc94a8cb261bb141cd0f7b) failed!
Build # 373 on master (be3ab291e36a90856d6d16c311eaafde7a95bfaf) failed!
Build # 374 on master (80d6b99eaaa655cc01e1c5cf1ba15e8c45cb9b82) failed!
Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!