Storybook: Setting showLeftPanel does nothing without showDownPanel

Created on 8 Aug 2017  路  7Comments  路  Source: storybookjs/storybook

If showLeftPanel is true, the left panel isn't shown unless showDownPanel is true.

I'd suggest merging these two into a single option like panelLocation: "left" | "right" | "none"

options react merged

Most helpful comment

That's how storybook UI looks with

{
  showLeftPanel: true,
  showDownPanel: false,
}

screen shot 2017-08-08 at 12 42 24

Left panel (the one with navigation) is shown

Honestly, I find this naming (showLeftPanel, showDownPanel, and especially downPanelInRight, which is called "Action Logger position" in the shortcuts help) really confusing. I believe we should rename those to showNavigationPanel, showAddonsPanel, and addonsPanelPosition, respectively.

All 7 comments

That's how storybook UI looks with

{
  showLeftPanel: true,
  showDownPanel: false,
}

screen shot 2017-08-08 at 12 42 24

Left panel (the one with navigation) is shown

Honestly, I find this naming (showLeftPanel, showDownPanel, and especially downPanelInRight, which is called "Action Logger position" in the shortcuts help) really confusing. I believe we should rename those to showNavigationPanel, showAddonsPanel, and addonsPanelPosition, respectively.

definitely support the renaming of those.

Fixed with #1689

@Hypnosphi by convention we mark the issue as merged when the PR gets merged, and close the issue only once the code is actually released. See:

https://github.com/storybooks/storybook/blob/master/CONTRIBUTING.md#closing-issues

Ok, so I shouldn't use the "Fixes #N" magic as I did before?

yeah i think we want the issues to only show up as fixed when end users can actually install the fix from NPM 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

tirli picture tirli  路  3Comments

sakulstra picture sakulstra  路  3Comments

miljan-aleksic picture miljan-aleksic  路  3Comments

MrOrz picture MrOrz  路  3Comments

dnlsandiego picture dnlsandiego  路  3Comments