Storybook: Warning: Failed prop type: Invalid prop `knob.value` of type `boolean` supplied to `BooleanType`, expected `string`.

Created on 18 Jun 2017  路  9Comments  路  Source: storybookjs/storybook

Warning: Failed prop type: Invalid prop `knob.value` of type `boolean` supplied to `BooleanType`, expected `string`.
    in BooleanType (created by PropField)
    in PropField (created by propForm)
    in form (created by propForm)
    in propForm (created by Panel)
    in div (created by Panel)
    in div (created by Panel)
    in Panel (created by DownPanel)
    in div (created by DownPanel)
    in div (created by DownPanel)
    in div (created by DownPanel)
    in DownPanel (created by Container(DownPanel))
    in Container(DownPanel) (created by Layout)
    in div (created by Layout)
    in div (created by Pane)
    in Pane (created by SplitPane)
    in div (created by SplitPane)
    in SplitPane (created by Layout)
    in div (created by Pane)
    in Pane (created by SplitPane)
    in div (created by SplitPane)
    in SplitPane (created by Layout)
    in div (created by Layout)
    in Layout (created by Container(Layout))
    in Container(Layout)
    in div
knobs bug merged

Most helpful comment

Will be fixed in the next release

All 9 comments

Will be fixed in the next release

@alexandrebodin any ETA on next release?

@alexandrebodin FYI our convention is to not close issues until the feature/fix has actually been released so I'm reopening this. 馃憤

Add close #1316 in the commit. When it's merged into main branch. This issue will be closed automatically

@Stupidism our convention is to close when we actually issue release, which is not necessarily when things get merged tomaster so until we change our convention please don't do this. Thanks for the suggestion though! cc @tmeasday @ndelangen

The idea is to avoid people opening duplicate issues for bugs that have already been fixed (but not released). As GH doesn't surface closed issues very obviously, it's better to leave them open until release.

released in v3.1.5. closing.

i'm seeing this same problem @storybook/[email protected]

https://github.com/storybooks/storybook/pull/6242/files#diff-1ef64f4620ba27403ef22d0b335bc8afR12 shows what i mean

Same Issue:

export let Example = () => {
  const showOptional = boolean("Disabled", [true, false], false);
  return (
    <fieldset className="row">
      <RadioButton
        label={text("RadioButton one", "Radio one...")}
        name="test-radio"
        value="option1"
        onClick={action("Checkbox checked")}
      />
      <RadioButton
        label={text("RadioButton two", "Radio two...")}
        name="test-radio"
        value="option2"
        onClick={action("Checkbox checked")}
      />
      <RadioButton
        label={text("RadioButton three", "Radio three...")}
        name="test-radio"
        value="option3"
        disabled={showOptional}
        checked={showOptional === false ? boolean("Checked", false) : null}
      />
    </fieldset>
  );
};
Was this page helpful?
0 / 5 - 0 ratings