Stockfish: 'make clean' doesn't remove downloaded nets

[GBeauregard]

After https://github.com/official-stockfish/Stockfish/commit/ea6220f3813e5b76b444a02905eaf2c556bdb368, profile-build produces new files that aren't cleaned up/removed with make clean (the downloaded NNUE nets). This means that as the default net changes the src directory will grow and require manual cleaning not covered by make clean.

[vondele]

that's on purpose as downloading the nets takes time, and make clean is common. I would rather consider it 'source' (but for technical reasons not part of the github history), not generated files.

[GBeauregard]

that's on purpose as downloading the nets takes time, and make clean is common. I would rather consider it 'source' (but for technical reasons not part of the github history), not generated files.

I noticed https://github.com/official-stockfish/Stockfish/issues/2981 proposes to literally include it in the source, so I'm linking for reference.

[ddugovic]

I don't know what I'm talking about, but could making NNUE nets a submodule somehow allow Git to track the maps without them appearing in this project's history?

[gvreuls]

How about

netclean:
    @rm -f nn-*.nnue

make netclean

[GBeauregard]

How about

netclean:
    @rm -f nn-*.nnue

make netclean

I think this is a nice solution that addresses the concerns.

[vondele]

but I wonder how many people will recall the 'netclean' target, as opposed to just execute rm nn-*.nnue

[vondele]

I'll close this, I think the current state is fine.