Stl: <yvals_core.h>: Update _MSVC_STL_UPDATE to November 2020
Explanation on our wiki: Macro _MSVC_STL_UPDATE
Previous issue: #1338
This issue is intended for a new contributor (especially one new to GitHub) to get started with the simplest possible change.
Please feel free to submit a pull request if there isn't one already linked here - no need to ask for permission! :smile_cat:
You can (and should) link your pull request to this issue using GitHub's close/fix/resolve syntax.
StephanTLavavej
All 5 comments
Hello, I would like to work on this issue.
avinal
on 10 Nov 2020
Please do!
mnatsuhara
on 10 Nov 2020
I have added a pull request please review.馃槄
avinal
on 10 Nov 2020
Perhaps future issues should add something to the effect of
"If there's currently no pull request/this issue isn't labelled "work in progress" please feel free to submit a pull request"
SuperWig
on 11 Nov 2020
Thanks @SuperWig - I have edited this issue's text so it'll be copy-pasted for the next issue. Hopefully this will make it even easier for contributors to get started - asking for permission to begin work is very polite :heart_eyes_cat: and common among new contributors (thank you @avinal!) but introduces additional delay until a maintainer can respond. In the unlikely event that we receive two near-simultaneous PRs, it would be quite simple to credit both contributors in the history, and both contributors would have the experience of preparing and submitting the PR, so no work would be wasted.
StephanTLavavej
on 12 Nov 2020
Related issues
StephanTLavavej
路
12Comments
Andersama
路
16Comments
zeux
路
18Comments
StephanTLavavej
路
10Comments
MahmoudGSaleh
路
20Comments
Most helpful comment
Thanks @SuperWig - I have edited this issue's text so it'll be copy-pasted for the next issue. Hopefully this will make it even easier for contributors to get started - asking for permission to begin work is very polite :heart_eyes_cat: and common among new contributors (thank you @avinal!) but introduces additional delay until a maintainer can respond. In the unlikely event that we receive two near-simultaneous PRs, it would be quite simple to credit both contributors in the history, and both contributors would have the experience of preparing and submitting the PR, so no work would be wasted.