Stencil version:
@stencil/[email protected]
I'm submitting a:
[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, use one of these channels: https://stencil-worldwide.herokuapp.com/ or https://forum.ionicframework.com/
Current behavior:
The es6-collections library is run first and works great.
When added to an Angular 6 project (which includes the core-js map/weakmap/etc polyfills), the constructor of the polyfill is modified due to an iterable shortcoming (not sure exactly what). Once the constructor is modified, this line
if (!this || this.constructor !== b) return new b(a);
...from es6-collections will always identify the constructor as not 'b', so it runs into a stack overflow in IE11 while loading an angular application.
Expected behavior:
The Ancient One (IE11) still functions as expected: Slowly, painfully, and with lots of excess code to make it behave until we can put it on the trash heap.
Steps to reproduce:
I was able to reproduce it in the following:
git clone -b IE11-polyfill-fun [email protected]:cary-smith/stencil-component-starter.gitnpm inode_modules/@stencil/core/dist/client/polyfills/es5/map.js fileRelated code:
(function(e) {
function d(a, b) {
function c(a) {
console.log("IE still exists and makes us all sad...");
if (!this || this.constructor !== c) return new c(a);
npm startOther information:
This blocks our ability to stay current with all the new kick-assery you folks keep implementing and may side-affect other devs at some point. We want to stay in the loop!
Thanks for the awesome software.
I'm facing same issue. I think es6-collections is colliding with other existing polyfill.
One other note: es6-collections is deprecated as noted on their github readme.
Is there a fix or workaround for this? We're still on Stencil 15.2. The latest 16.2 did not seem to fix this still.
@dgibson666 not as long as they continue to use the deprecated polyfill 馃槥. I think a PR would be the most effective in this case.
I have the same issue.
@cary-smith @dgibson666
Did you start working on it?
Cheers!
@stefanmeschke - Sadly have not yet had the break to take a look.
I am kinda hoping this does not get bot-closed. Is there any possibility of a different approach?
Agreed. I'm surprised they shipped ionic 4 with this still outstanding. We're still unable to upgrade past .15.2 because of this issue.
Experiencing issues here as well (cc. @adamdbradley )
same here
We've developed a bug fix for this issue. You can find it here: https://github.com/AOEpeople/stencil/tree/fix-ie11-polyfill
Let's hope they will check it fast and merge it, if the solution fits... 馃檹馃徎
Briefly checking [email protected], this issue still exists.
Most helpful comment
We've developed a bug fix for this issue. You can find it here: https://github.com/AOEpeople/stencil/tree/fix-ie11-polyfill
Let's hope they will check it fast and merge it, if the solution fits... 馃檹馃徎