Steem: STEEMIT BUG DEC 6th (TAGS NOT WORKING IF USEING 5 TAGS)

Created on 7 Dec 2016  路  7Comments  路  Source: steemit/steem

Hey guys I came across a bug today and its happening with many users not just myself. If you post a post with specifically "5 tags". Your post will only show up under the first tags topic. This bug does not apply if you use 4 or less tags. Here is the post on it. Thanks.
https://steemit.com/steemit/@jacobcards/possible-hardfork-bug-tags-not-working

Most helpful comment

The bug is in the tags plugin.

If the post is safe_for_work, i.e. this branch of the if statement is reached, then the size of lower_tags will increase by 1 assuming there were no empty string tags in the tags field of the json_metadata. (By the way, that is another bug that can allow NSFW content with negative net_rshares to show up in the default feed. You really should filter out any empty string tags here.) So if there were 5 unique non-empty tags (one of which was also the category of the post) specified for the post, lower_tags would actually have a size of 6 by this line, which would mean that this condition would incorrectly be true, thus causing, via this line, the post to show up in the default feed and under the tag for its category but no where else.

By the way, this bug can also be triggered (not actually tested, and I suppose it can't be triggered via the steemit.com interface) with 4 non-empty tags if none of those tags are the category (parent_permlink) of the post.

All 7 comments

The bug is in the tags plugin.

If the post is safe_for_work, i.e. this branch of the if statement is reached, then the size of lower_tags will increase by 1 assuming there were no empty string tags in the tags field of the json_metadata. (By the way, that is another bug that can allow NSFW content with negative net_rshares to show up in the default feed. You really should filter out any empty string tags here.) So if there were 5 unique non-empty tags (one of which was also the category of the post) specified for the post, lower_tags would actually have a size of 6 by this line, which would mean that this condition would incorrectly be true, thus causing, via this line, the post to show up in the default feed and under the tag for its category but no where else.

By the way, this bug can also be triggered (not actually tested, and I suppose it can't be triggered via the steemit.com interface) with 4 non-empty tags if none of those tags are the category (parent_permlink) of the post.

confirmed by @NateBrune

@mvandeberg this patch removes NSFW flagging from the backend, has someone from the frontend team confirmed that the frontend handles this now?

So if I understand properly, nsfw tag won't show up on the public page anymore?

To keep NSFW off frontpage, || here should be &&

We are leaving the filtering the web front end with the plan to eventually filter based on user preference.

This was merged and released in 0.16.1

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Ulfrinn picture Ulfrinn  路  5Comments

mahnunchik picture mahnunchik  路  7Comments

finleyexp picture finleyexp  路  4Comments

pfunks picture pfunks  路  6Comments

mvandeberg picture mvandeberg  路  6Comments