Status-react: Cancel button is an overkill for extension confirmation dialog

Created on 17 Oct 2018 · 13Comments · Source: status-im/status-react

Description

Type: Bug

Summary: There is a confirmation dialog when adding an extension. It contains Cancel button which is not necessary as this dialog just confirms the extension values are added to db after install button is pressed.

Expected behavior

Remove the cancel button. Show alert view with 1 button https://facebook.github.io/react-native/docs/alert

Actual behavior

Reproduction

Open Status
Enable dev mode
Go to extensions and add one

...

Alert · React Native
Launches an alert dialog with the specified title and message.

bounty-awaiting-approval bounty-s bug extensions

Source

asemiankevich

👍1

All 13 comments

Hi, I'd be really interested to work on this. I've previously worked developing react-native apps, and have become really interested in what status are working towards. Happy to help on this repo if you have space :)

samthomson on 10 Nov 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__This issue now has a funding of 120.0 DAI (120.0 USD @ $1.0/DAI) attached to it as part of the Status.im fund.__

If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
- Want to chip in? Add your own contribution here.
- Questions? Checkout Gitcoin Help or the Gitcoin Slack
- $47,759.80 more funded OSS Work available on the Gitcoin Issue Explorer

gitcoinbot on 13 Nov 2018

Have at it @samthomson - deploying the bounty now. Please just don't abandon me on the website 😉 ❤️

andytudhope on 13 Nov 2018

😄1

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work has been started__.

These users each claimed they can complete the work by 2 months, 3 weeks ago.
Please review their action plans below:

1) frederikbolding has been approved to start work.

Start learning the codebase, Figuring out where the extension code is located, Fixing the bug, Testing and pushing the fix.

Learn more on the Gitcoin Issue Details page.

2) seniuus has applied to start work _(Funders only: approve worker | reject worker)_.

Hi, I am pretty interested in this work.
I've worked with Clojure, so I think I can manage to do something right.
Regards

Learn more on the Gitcoin Issue Details page.

gitcoinbot on 13 Nov 2018

I'm available for this as well, if needed 😄

FrederikBolding on 13 Nov 2018

👍1

No stress @FrederikBolding - here is another one for you: https://github.com/status-im/status-react/issues/6594 (same bounty amount). We can tag team them, as there are A LOT of bounties we want to put out over the next few weeks.

StatusSceptre on 13 Nov 2018

I'm going to drop of this issue for now. I foolishly didn't realise (until I now clone and try building the repo) that the mobile app is also written in clojure and transpiled to react-native (I thought closure was elsewhere in the status ecosystem...). Impressive, but I'd rather spend some time familiarising myself with closure and the build tools in this repo before clogging up time on this. @FrederikBolding maybe you can get it after all :upside_down_face: I think you might find the correct place to edit here: https://github.com/status-im/status-react/blob/develop/src/status_im/extensions/registry.cljs#L62:L65

GitHub
status-im/status-react
a free (libre) open source, mobile OS for Ethereum - status-im/status-react

samthomson on 14 Nov 2018

Let me know @FrederikBolding and thanks @samthomson - you can find a great place to start here (though there is some debate about whether going full emacs is necessary. There are also Clojure plugins for VSCode etc). https://www.braveclojure.com/introduction/

Introduction | Clojure for the Brave and True

Also, see this discuss post for some other work that will be happening in React at least (not Native, but still): https://discuss.status.im/t/community-design-system/721

andytudhope on 14 Nov 2018

👍1

@andytudhope I'll give it a shot! 😄

FrederikBolding on 14 Nov 2018

Hi,
I've applied on this one. I am available ;)