Status-react: Implement EIP-712

[leroldary]

Description

Type: Feature

Summary: Implement ethereum/EIPs#712 (eth_signTypedData).

As EIP-712 is finally merged and both MetaMask and Trust Wallet will support it soon, it would be great if status would implement this too.

[sidsverma]

What mechanism can be used to sign in Status?

[jeluard]

MetaMask has now shipped its support.

[jeluard]

Blocked go side

[jeluard]

@sidsverma The older wai is to use personal_sign

[sidsverma]

@jeluard Yes, I tested it with personal_sign, and it works wonderfully on Status. But when will Status move to the latest eth_signTypedData_v3?

[jeluard]

@sidsverma We will start working on it soon. Do you have a specific use case or existing DApp relying on it?

[dshulyak]

what is eth_signTypedData_v3? is it any different from EIP-712 spec?

[sidsverma]

No, eth_signTypedData_v3 is what EIP-712 spec requires you to do.
@jeluard I am building one. So, no, not yet.

[dshulyak]

there is no v3 tag in the EIP though

[nuo-admin]

Check this out:
https://medium.com/metamask/eip712-is-coming-what-to-expect-and-how-to-use-it-bb92fd1a7a26

On Wed, Oct 17, 2018 at 11:10 PM Dmitry Shulyak [e-mail]
wrote:

there is no v3 tag in the EIP though

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/status-im/status-react/issues/5461#issuecomment-430886750,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApchkSDDspBMZ9lg1fEAFbP2RtWqwCywks5umBtFgaJpZM4V5o8J
.

--

Thanks

Siddharth Verma
Co-Founder, Nuo
[phone]

[dshulyak]

@flexsurfer @jeluard signTypedData wa implemented and will be added with the next update of status-go. i assumed that the integration with status-react will be done the same way as for signing raw data and transactions. So, there is a binding for this call with a following signature https://github.com/status-im/status-go/blob/develop/lib/library.go#L356

GitHub

status-im/status-go

The Status module that consumes go-ethereum. Contribute to status-im/status-go development by creating an account on GitHub.

[okwme]

still waiting for this, any progress?
would really love for my app's authentication to work with Status
https://clovers.network

Clovers

Welcome | Clovers

Discover, collect & trade cryptographic icons.

[jeluard]

@flexsurfer Did we make progress on this?

[flexsurfer]

@jeluard only on go side i believe, if we want to make progress we need to add it in our roadmap

[okwme]

pls do 🙏
this is an essential feature to allow users with no ether to participate

[rstormsf]

TrustWallet, Metamask, Nifty Wallet - all of them support this wonderful EIP-712
Please check it out as well

Don't forget to support
window.ethereum.sendAsync
as well

https://twitter.com/ethstatus/status/1092298498425450496

Twitter

Status on Twitter

“@rstormsf @imTokenOfficial @TrustWalletApp Thanks for reaching out! We like to stay on top of most relevant EIPs — will forward this over to the core team :) an issue would be great too. https://t.co/b4TRxuriVY”

Link to test it on Metamask
https://rstormsf.github.io/js-eth-personal-sign-examples/

[pablanopete]

@flexsurfer @jeluard is this issue trivial enough to add a bounty to since it's not on the current roadmap and we've had a few asks for it?

[jeluard]

@pablanopete It's on our roadmap now.

[jeluard]

@pablanopete Can it be removed from bounties?

[pablanopete]

Yup no problem! Thanks @jeluard

[jeluard]

@sidsverma @okwme @rstormsf It's now available in latest nightly! Please give it a try

[okwme]

doesn't work for me on newest testflight version : \
we're using this implementation:
https://github.com/clovers-network/clovers-dapp/blob/b80c4e90d889b6cfb5ffc8b0b1d892092b5ce40e/src/store/actions.js#L371

[jeluard]

@flexsurfer Maybe you could take a look at this one?

[jeluard]

@okwme What exactly doesn't work? Can you provide more details?

[flexsurfer]

@okwme @jeluard i believe it's only available in nightlies, not in release yet, will be available in next release

[jeluard]

Oh right! It's nightly only, not TestFlight @okwme

[okwme]

see the sign available in app now but it crashes the app when i submit ;_;

[okwme]

opened an issue at #8729