Status-react: Update styles of system messages bot

[denis-sharypin]

User Story

As a user and admin of group chat, I want to have more clarity on who sends me system messages.

Description

Type: Bug

Summary:
As admin of group chat I see system messages when adding or removing somebody to/from the existing group chat. Those messages have broken userpick and you can tap on to see profile of this bot. We have to fix it.

Expected behavior

Actual behavior

Reproduction

• Open Status
• Create a group chat with Jarrad
• Removed Jarrad from the chat from the group chat profile screen

Solution

Summary:

1. Add a userpick
   
   
   
   1. Rename this bot from System to System message
   
   
   2. Don't show a profile of this bot (don't allow user to tap on the userpick )
   
   
   3. Color chat bubble of the system message to #DBE1E5
   
   

Additional Information

• Status version: nightly 17.04.18
• Operating System: Android|iOS

[denis-sharypin]

Userpicks, let me know if you need different sizes

[debragail]

Should System Messages be modeled as a bot? Currently system-message is defined without a name or photo-path.

[debragail]

Also, reconsider naming System Messages. Status Bot is a better UX. If the feature does not have a profile pic and does not have a name but instead is a printed string then consider it not being named but simply printing the status in small grey lettering.

[denis-sharypin]

@debragail Thanks for your suggestions.

What is a bot for users? A small program running over your chat which was created and invited by someone. Who has invited this bot? Who has created it? What the real purpose of this bot? Why don't I see Status bot in a list of members of my group chat? To not produce those questions we consider to call it System message. It has neutral meaning.
We use and would use this visual style of a message in different cases where more suitable to have it as a chat message.

Regarding modeling, can @jeluard or @flexsurfer give a hand and help here?

[debragail]

this feature enhancement looks like a bot since it it has a profile pic. I would expect system message to be just a styled printed string in the message instead of the way it is currently designed.

[debragail]

when I went to code the changes I realized system message was not modeled as a bot and was only applicable to group messages which seemed the improper place to style “System message” and indeed needs a PRD

[yenda]

@debragail system messages are not bots, they are created with the system-message function and added by passing them to the fx-producing function receive here

They should work for 1-1 chats as well.

The simplest way I can think of for them to have a picture is to have a condition in status-im.chat.views.photos for from = "system".

[debragail]

I think they should be modeled as a bot that only prints system messages.

[rachelhamlin]

@debragail @yenda changing the model adds time/complexity that I don't think is worth introducing at this point. With regard to presentation, we can test system message with users once the update is released.

[pablanopete]

cc @andytudhope needs revoked.