Status-react: Show anonymous usernames instead of Unknown contact in public chat

[annadanchenko]

Description

Type: Bug

Summary: All participants in public chat have "unknown contact" title. It would be easier to distinguish several users if anonymous usernames are shown instead of same Unknown contact title.

Expected behavior

Anonymous username is shown as a user name in public chat to other participants

Actual behavior

Unknown contact is shown as a user name in public chat to other participants

Reproduction

• Open Status
• Join public chat as contact A
• Join public chat as contact B
• as contact A: write a message to public chat
• as contact B: check the user name shown above the message from A in public chat

Additional Information

• Status version: 0.9.9
• Operating System: iOS and Android

[annadanchenko]

@mlahia Unfortunately, instead of anonymous username there is Revolving Pikeperch name shown. Steps:

• User with anonymous name Oldlace Proud Queenslandheeler is not in my contacts. This anonymous username was generated during account creation and user did not set other name.
• We joined public chat 'testhere'.
• I've sent message "A"
• User sent message "B"
  Expected: I see that message B is sent by user Oldlace Proud Queenslandheeler
  Currently: I see that message "B" is sent by "Revolving Wide Pikeperch"
  Log and video from my side (see from 00:22, Google Pixel XL, Androi 8.0.0 real device): https://app.testfairy.com/projects/4803622-status/builds/7127704/sessions/3/?accessToken=P/0w7X7bGCXJZS6n0HDlvjSidUs
  Log and video from user's side (see from 00:15, iPhone 6s, iOS 10.3.3, real device): https://app.testfairy.com/projects/4803590-status/builds/7127482/sessions/7/?accessToken=Ic3FlDekGbHL-MQIqiC-YKnMppQ
  Issue:
  

[SHA-2048]

OK very sorry for that. I'm having some troubles installing the app on my old macbook. I'll submit a fix as soon as I manage to test properly. Thanks !

[SHA-2048]

@annadanchenko with the help of @lahian I've been able to test it on the iPhone simulator. I've update the PR with a working version. Please take a look when you have time :) . Thanks !

[churik]

Issue is not fixed

[SHA-2048]

@churik can please put some details?
I've tested the fix on an iphone 6 simulator and the anounymous user name was displaying correctly instead of "Unkown contact"

[churik]

@mlahia I checked wrong PR (#2452), sorry for mistake, will check on #2815