Status-react: :navigation-stack is grows on switching tabs

[flexsurfer]

these screens don't have back buttons so i think we don't need to store tabs in the stack,
and on Android it's not good behavior to go back through all stack

[rasom]

Looks like it would be better to use :navigation-replace for switching between tabs to avoid this.

[mathvdh]

Hi, I'm trying to handle this as an appetizer ... It seems quite simple :)

After looking a bit I only have one issue with the proposed solution:

If we use :navigation-replace to switch between tabs, we don't update :prev-tab-view-id and :prev-view-id when switching tabs. An alternative I would like to propose is to replace the call to push-view with replace-view in the handler for :navigate-to-tab. So we still update those but don't add to the navigation-stack ?

If OK for you guys I'll submit a PR with this fix (a one-line fix really :)

[rasom]

Hi, @mathvdh , it sounds fine, lets try :)

[tartakovsky]

Should be closed?

[jarradh]

yes, PR didn't include a fixes #747 which allows us to rely on Github auto-closing, good catch @etartakovsky