Statping: Admin password environment variable naming seems wrong

[MeYoGui]

Describe the bug

Using the wiki page : https://github.com/statping/statping/wiki/Environment-Variables I tried to setup a default "admin password" using the environment variable "ADMIN_PASS" without success.

The problem is that the naming of this variable seems wrong. Indeed, in "types/configs/connection.go" on line 87 we can see that it's looking after a "ADMIN_PASSWORD" environment variable (instead of "ADMIN_PASS".

When I changed it to the correct name, it worked nicely :)

To Reproduce

Steps to reproduce the behavior:

1. I'm using version: 0.90.39
2. I configured environment variable "ADMIN_PASS" (with my password as a value)
3. I cleaned up my database
4. I started statping and see that the admin password is set to the default value (admin) and not the one that I've put into the env variable.

Expected Behavior

When setting the admin password in env variable I should be able to connect to the dashboard using the env variable value.

(I have already changed the wiki so nobody will have this problem but I think that a consistency pass on the naming of that variable should be done (ADMIN_PASS vs ADMIN_PASSWORD)

Thank you :)

[kvpt]

I think it's a duplicate of the issue #542.

[DanielRuf]

Not really a duplicate imo.

[hunterlong]

Ahhh.... nice catch.

https://github.com/statping/statping/blob/9161c5f99f551331af8af246382b844b40aee4ae/types/configs/load.go#L65

https://github.com/statping/statping/blob/f9ab56073615708c4e97077018f85835db31659a/utils/configs.go#L49

Let's use ADMIN_PASSWORD. Not ~ADMIN_PASS~. PR: https://github.com/statping/statping/pull/595

[hunterlong]

https://github.com/statping/statping/pull/598

[MeYoGui]

Thank you and good job for this awesome tool :)

[nclonts]

Thank you for the update. This was an issue for my installations as well.

[hunterlong]

I'm going to close this issue.

Do not use ~ADMIN_PASS~ as an environment variable, use ADMIN_PASSWORD.