Statping: Statping says service failure occured, even when there wasn't

[ryan77627]

Describe the bug
When I go to my status page, the services say a failure was usually within the last 5 minutes. If I click on the service, there haven't been any failures for the past 5 days. Is "last failure" supposed to say "last checked"?

To Reproduce
Steps to reproduce the behavior:

1. I'm using version: 0.80.48
2. Go to the status page linked above, look at last failure time, click on a service and compare that to the failure log.

Screenshots
Screenshots from "User DB" Service:

[ryan77627]

I just noticed this is reference in pull request #62 - While I do not necessarily agree with what was changed, it at least has attention. IMO, I would prefer the time of the last hit to be said in the bar, not last failure. It seems as though line 125 of services.go says failures while checking hits. It should just be "Last checked at". I would change this and build it on my computer to test it but I have trouble compiling go programs and don't have the time to make a VM that I feel comfortable messing around with in terms of packages and such.

[JoeRegnier]

I think that last failure at a glance has great value. I am always assuming that the ping stats are regularly running and so as long as uptime 24hrs, uptime for 7 days, and avg response is there statping is on schedule. But what has helped on a number of occasions is checking to see a failure or two occurred overnight/weekend and we need to dig into causes. It's possible my assumption is flawed and both points of information would be valuable.

[ryan77627]

No I agree, perhaps I worded it incorrectly in my OP. What I meant was the text in the bar isn't necessarily reflecting the last failure time for me, but the last time it was checked. For example, the bar may say "Last failure was 4 minutes ago" (Would show actual date but shortened for brevity) I'd click the service then the failure chart would say last failure was hours if not days ago. I thought the wording on the bar was a translation error and was supposed to say "last checked"

Sorry for the confusion!

[smithje]

I noticed this also - every service that has ever had a failure is showing a failure at the last checkin time. This line is wrong: https://github.com/hunterlong/statping/blob/master/core/services.go#L205
It should be last[0] instead of hits[0]

[ryan77627]

That must be why it's doing what I said! Thanks! When I get time, I'm gonna
attempt to build with this change to verify it worked.

On Tue, May 14, 2019, 10:56 AM Jeremy Smith [e-mail]
wrote:

I noticed this also - every service that has ever had a failure is showing
a failure at the last checkin time. This line is wrong:
https://github.com/hunterlong/statping/blob/master/core/services.go#L205
It should be last[0] instead of hits[0]

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/hunterlong/statping/issues/144?email_source=notifications&email_token=AD7T7I2D3KDSZEVCBY6OBYTPVLHLJA5CNFSM4GYZ4J62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLYCMY#issuecomment-492273971,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD7T7I34BQ365K5BVNEBPYTPVLHLJANCNFSM4GYZ4J6Q
.

[hunterlong]

Hey @ryan77627 and @smithje , thanks for the update. I added your recommended changes, and I'm now monitoring the failure checkin timestamp.
https://github.com/hunterlong/statping/commit/355e7e325b53a95762c1eaaa7937e2303eed8157#diff-8873ce450d8e20a4385bb64f365af8dfL205

[github-actions[bot]]

This issue hasn't had any updates in a while. If this is still a problem, please create a new issue.