Starship: Branch Name "Master" always shown in ZSH

Created on 11 Apr 2020  路  3Comments  路  Source: starship/starship

starship bug-report => Results in: 414 Request-URI Too Large -nginx

Bug Report

Current Behavior

Branch Name "Master" always shown in ZSH - when I'm not in a git repo

Expected Behavior

When I'm not in a repo it should not show up a branch name.

Additional context/Screenshots

image

Environment

  • Starship version: starship 0.40.0
  • Shell type: zsh
  • Shell version: zsh 5.8 (x86_64-apple-darwin19.3.0)
  • Shell plugin manager: antigen
  • Terminal emulator: iTerm2 Build 3.3.9
  • Operating system: macOS 10.15.4
馃悰 bug

Most helpful comment

Looks like this bug slipped into the v0.40.0 release.
I'm quickly drafting v0.40.1 as a hotfix. 馃敡

All 3 comments

Same for fish shell.

Environment

  • Starship version: 0.40.0
  • fish version: fish, version 3.1.0
  • Operating system: Mac OS 10.15.4
  • Terminal emulator: iTerm.app 3.3.9

Looks like because of this changes: https://github.com/starship/starship/blame/master/src/modules/git_branch.rs#L33-L36

It won't distinguish between no repository and bare one. 馃し

Same in bash and fish
image

Environment

  • Starship version: 0.40.0
  • fish version: 3.1.0
  • bash version: 5.0.16
  • Operating system: Linux (5.4.28 - Manjaro)
  • Terminal emulator: kitty (0.17.2)

Looks like this bug slipped into the v0.40.0 release.
I'm quickly drafting v0.40.1 as a hotfix. 馃敡

Was this page helpful?
0 / 5 - 0 ratings