Starlette: Strip trailing slash ( / ) from URL route strings.

[gnat]

Hey all, an optional trailing slash seems to be pretty standard on most websites, but in Starlette, you must add separate routes to handle them. Example:

routes = [
    Route('/', PlainTextResponse("home")),
    Route('/test', PlainTextResponse("test")),
    Route('/test/', PlainTextResponse("I need to be added separately?!"))
]

app = Starlette(routes=routes)

Could a route = route.rstrip("/") please be added to https://github.com/encode/starlette/blob/master/starlette/routing.py in class Router before running the match so these routes don't have to be manually added? Thanks!

[blueyed]

Not sure about this myself - seems like a bit too much magic to have by default.

But you might want to create a PR with your suggested patch already, so this can be discussed at the code level.

[blueyed]

btw: you can use "/path/?" to match an optional slash..

[tomchristie]

Absolutely, yup.

We already handle the converse case, but for some reason I've only got the behavior in one way right now.

python routes = [ Route('/', PlainTextResponse("home")), Route('/test/', PlainTextResponse("test")), # Route('/test', PlainTextResponse("I do not need to be added separately")) ]

[achien]

I am seeing this issue again. From the history of routing.py it looks like #707 might have been reverted by #704?

[blueyed]

Yeah, too bad https://github.com/encode/starlette/pull/707 did not have a test.
@tomchristie please re-open / fix it.
@achien might be helpful to know which commit from #704 it was - have not checked it myself, but there are several.

[achien]

@blueyed it looks like the merge commit caused the regression https://github.com/encode/starlette/pull/704/files#diff-34fba745b50527bfb4245d02afd59246, specifically around line 617 of the old version and 564 of the new version.