Standard: Publish standard repo to https://github.com/dotnet/versions/tree/master/build-info/dotnet

[ericstj]

We need to get the maestro automatic updates of NETStandard.Library produced from this repo and consumed in CoreFx and core-setup.
/cc @dagood

[ghost]

I have the work in place, but I need some help configuring appropriately, @dagood would you be so kind as to give this a once over? I am getting a 404 at the moment.

Build definition is here:
https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=546662&_a=summary

[dagood]

Sure, a few things I see:

1. That definition's using dotnet-bot and dotnet-helix-bot's email, but the token is for dotnet-build-bot. (404 is probably an auth error. I might have shown you an old definition with dotnet-helix-bot, sorry about that.) Those variables should be dotnet-build-bot and dotnet-build-bot's email.
2. VersionsRepoPath should be build-info/dotnet/standard [edit] build-info/dotnet/standard/master, not pointing to corefx. Corresponds to the dirs in https://github.com/dotnet/versions/tree/master/build-info/dotnet.
3. ShippedNuGetPackageGlobPath doesn't look like it will find any packages... I think bin/packages/Debug/*.nupkg is what you need, but it's not quite clear from the build log. (Probably Release for the official builds?)

[ghost]

Current values:
GitHubUser="dotnet-build-bot"
GitHubEmail="[email protected]"
GitHubAuthToken="$(PB_GitHubAuthToken)"
VersionsRepoOwner="$(VersionsRepoOwner)"
ShippedNuGetPackageGlobPath="bin/packages/Debug/*.nupkg"
VersionsRepoPath="build-info/dotnet/$(PB_GitHubRepositoryName)"

Still getting a 404.

[ghost]

dotnet/versions#120 was a requirement.

[dagood]

dotnet/versions#120 was a requirement.

Just a note that we needed to seed the files because standard's BuildTools version doesn't include https://github.com/dotnet/buildtools/pull/1287.

[ghost]

Awesome, and https://github.com/dotnet/versions/blob/master/build-info/dotnet/standard/master/Latest.txt should reflect a package from my test build. I am going to open up the PR now that everything appears to be wired up correctly.

[ghost]

Merged https://github.com/dotnet/standard/pull/189

Doing test runs (making sure things are configured appropriately)

[ghost]

Things are almost lined up. There appears to be an issue where my build definition is not pulling the latest version of the repository? As a result of this it isn't finding the correct VersionsTools.targets. I logged in to one of the machines, pulled the latest and did a build so I am confident there is another configuring error somewhere. I will look this over tomorrow.

https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?context=Mine&path=%5C&definitionId=5080&_a=completed

[dagood]

Looking at this: https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?buildId=549360&_a=summary the issue is that I mistook -g for -p. The GitHub token needs to be with the other key=value pairs in -g (global pipeline variables). I didn't see any issues with the commit hash it was using.

[ghost]

Thanks for the help Davis. This + another missing global property were the last pieces of configuration I needed. Things appear to be working now - https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_build/index?context=mine&path=%5C&definitionId=4752&_a=completed

[ghost]

FYI: Versions are posted here:
https://github.com/dotnet/versions/tree/master/build-info/dotnet/standard/master

[ericstj]

@dagood I'm not seeing maestro update core-setup with this repo. Is something missing?

/cc @mellinoe @weshaggard

[dagood]

It looks like Maestro isn't triggering the core-setup-general executor at all anymore, even though the file in the subscription is definitely changing. Looking into it.

/cc @dleeapho

[dagood]

Maestro seems to have a partially revoked PAT, and hasn't triggered an auto-update in Core-Setup since ~2017-02-13. I'm working on getting a new PAT to give Maestro so Core-Setup auto-updates will work again.

[dagood]

Core-Setup now gets auto-updates again, fixed by https://github.com/dotnet/versions/pull/135. ex: https://github.com/dotnet/core-setup/pull/1604